Skip to content

[vxlan]Fixing L2MC vlan member caching issue#2378

Merged
prsunny merged 2 commits intosonic-net:masterfrom
dgsudharsan:p2mp_l2mc_fix
Jul 15, 2022
Merged

[vxlan]Fixing L2MC vlan member caching issue#2378
prsunny merged 2 commits intosonic-net:masterfrom
dgsudharsan:p2mp_l2mc_fix

Conversation

@dgsudharsan
Copy link
Copy Markdown
Collaborator

What I did
Fixed caching issue when L2MC member is removed. During the L2MC member removal, the local variables are modified but not updated to cache. Since L2MC removal is not updated in cache, the same member being added again will be skipped as duplicate.

Why I did it
To fix the above mentioned issues. Without the fix, the same L2MC member removal and add will not work.

How I verified it
Flapped the remote end point and verified if it L2MC member is created again

Details if related

@dgsudharsan
Copy link
Copy Markdown
Collaborator Author

The coverage fails because we cannot add test to simulate the SAI failure scenario. This code is used to trigger the orchagent exit when any SAI call fails and this cannot be simulated in the vs.

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Jul 15, 2022

Diff coverage reported is for the failure cases which cannot be easily handled by VS tests. Manually verified and functional code has the coverage. Merging bypassing the diff check

Not covered:

                task_process_status handle_status = handleSaiSetStatus(SAI_API_VLAN, status);
                if (handle_status != task_success)
                {
                    m_portList[vlan.m_alias] = vlan;
                    return parseHandleSaiStatusFailure(handle_status);
                }

@prsunny prsunny merged commit 9d3a5c5 into sonic-net:master Jul 15, 2022
yxieca pushed a commit that referenced this pull request Jul 17, 2022
* [vxlan]Fixing L2MC vlan member caching issue
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
* [vxlan]Fixing L2MC vlan member caching issue
@dgsudharsan dgsudharsan deleted the p2mp_l2mc_fix branch March 9, 2023 02:02
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
* [vxlan]Fixing L2MC vlan member caching issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants