[vxlan]Fixing L2MC vlan member caching issue#2378
Merged
prsunny merged 2 commits intosonic-net:masterfrom Jul 15, 2022
Merged
Conversation
Collaborator
Author
|
The coverage fails because we cannot add test to simulate the SAI failure scenario. This code is used to trigger the orchagent exit when any SAI call fails and this cannot be simulated in the vs. |
Collaborator
|
Diff coverage reported is for the failure cases which cannot be easily handled by VS tests. Manually verified and functional code has the coverage. Merging bypassing the diff check Not covered: |
prsunny
approved these changes
Jul 15, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 17, 2022
* [vxlan]Fixing L2MC vlan member caching issue
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* [vxlan]Fixing L2MC vlan member caching issue
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [vxlan]Fixing L2MC vlan member caching issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed caching issue when L2MC member is removed. During the L2MC member removal, the local variables are modified but not updated to cache. Since L2MC removal is not updated in cache, the same member being added again will be skipped as duplicate.
Why I did it
To fix the above mentioned issues. Without the fix, the same L2MC member removal and add will not work.
How I verified it
Flapped the remote end point and verified if it L2MC member is created again
Details if related