Skip to content

[202111] Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234)#2313

Merged
liat-grozovik merged 1 commit intosonic-net:202111from
stephenxs:backport-dynamic-buffer
Jun 24, 2022
Merged

[202111] Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234)#2313
liat-grozovik merged 1 commit intosonic-net:202111from
stephenxs:backport-dynamic-buffer

Conversation

@stephenxs
Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs commented Jun 7, 2022 •
edited by liat-grozovik
Loading

What I did
This PR is to backport #2234

Why I did it
Support mock_test infra for dynamic buffer manager and fix issues found during mock test

How I verified it

Details if related

@stephenxs stephenxs force-pushed the backport-dynamic-buffer branch from f5df282 to cd2141f Compare June 7, 2022 09:43
@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Jun 7, 2022

@stephenxs can you please check if this can be moved to ready for review and re run checkers?

@stephenxs stephenxs force-pushed the backport-dynamic-buffer branch from 3c6c119 to f9e83b3 Compare June 7, 2022 13:09
@stephenxs stephenxs marked this pull request as ready for review June 7, 2022 22:40
@stephenxs stephenxs requested a review from prsunny as a code owner June 7, 2022 22:40
@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 7, 2022

Same issue as we saw on master - time out

@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 7, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 7, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 7, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv vivekrnv mentioned this pull request Jun 8, 2022
Merged
@stephenxs stephenxs mentioned this pull request Jun 13, 2022
Merged
@stephenxs stephenxs force-pushed the backport-dynamic-buffer branch from f9e83b3 to 27c5181 Compare June 15, 2022 00:22
@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 15, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 15, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik changed the title [202111] Backport: Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234) [202111] Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234) Jun 19, 2022
@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Jun 19, 2022

@stephenxs could you please check failures?

@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 20, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 20, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 20, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 22, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 22, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 22, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 22, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the backport-dynamic-buffer branch from 27c5181 to 10bfd51 Compare June 22, 2022 08:24
@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 22, 2022

All failures are the same

e = HTTPError('404 Client Error: Not Found for url: http+docker://localhost/v1.41/containers/create')

    def create_api_error_from_http_exception(e):
        """
        Create a suitable APIError from requests.exceptions.HTTPError.
        """
        response = e.response
        try:
            explanation = response.json()['message']
        except ValueError:
            explanation = (response.content or '').strip()
        cls = APIError
        if response.status_code == 404:
            if explanation and ('No such image' in str(explanation) or
                                'not found: does not exist or no pull access'
                                in str(explanation) or
                                'repository does not exist' in str(explanation)):
                cls = ImageNotFound
            else:
                cls = NotFound
>       raise cls(e, response=response, explanation=explanation)
E       docker.errors.ImageNotFound: 404 Client Error for http+docker://localhost/v1.41/containers/create: Not Found ("No such image: docker-sonic-vs:Azure.sonic-swss.20220622.13")

@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jun 23, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 23, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 23, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Support mock_test infra for dynamic buffer manager and fix issues fou…
961a158 
…nd during mock test (sonic-net#2234)

* Support mock_test infra for dynamic buffer manager and fix issues found during mock test
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Conflicts:
	tests/mock_tests/Makefile.am
@stephenxs stephenxs force-pushed the backport-dynamic-buffer branch from 10bfd51 to 961a158 Compare June 24, 2022 04:05
@liat-grozovik liat-grozovik merged commit d55ecd6 into sonic-net:202111 Jun 24, 2022
@stephenxs stephenxs deleted the backport-dynamic-buffer branch June 24, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@judyjoseph judyjoseph Awaiting requested review from judyjoseph

@neethajohn neethajohn Awaiting requested review from neethajohn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenxs @liat-grozovik @mssonicbld