[PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected by vivekrnv · Pull Request #2304 · sonic-net/sonic-swss

vivekrnv · 2022-06-01T17:08:48Z

What I did

Avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and does not attach any zero profile to the ingress pg when pfcwd is triggered

Revert changes related to #1480 where the retry mechanism was added to BufferOrch which caches the task retries and while the PG is locked by PfcWdZeroBufferHandler.

Revert changes related to #2164 in PfcWdZeroBufferHandler & ZeroBufferProfile & BufferOrch.

Updated UT's accordingly

How I verified it

UT's.

Ran the sonic-mgmt test with these changes sonic-net/sonic-mgmt#5665 and verified if they've passed.

Details if related

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

…nto pfc_pg

vivekrnv · 2022-06-11T20:38:49Z

/azpw run Azure.sonic-swss

mssonicbld · 2022-06-11T20:38:51Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2022-06-11T20:39:01Z

Azure Pipelines successfully started running 1 pipeline(s).

…d profies Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

stephenxs · 2022-06-22T02:43:29Z

orchagent/pfcactionhandler.cpp

-            return;
-        }
+    attr.id = SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE;
+    attr.value.u32 = SAI_BUFFER_POOL_THRESHOLD_MODE_STATIC;


Let's use dynamic mode and dynamic_th -8 for creating profile. this is what was used before
L 689

attr.value.u32 = SAI_BUFFER_POOL_THRESHOLD_MODE_DYNAMIC;

L 711

attr.value.u32 = SAI_BUFFER_PROFILE_THRESHOLD_MODE_DYNAMIC;

L 718~719

attr.id = SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH; attr.value.s8 = 0;

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

…nto pfc_pg

stephenxs · 2022-06-22T06:35:19Z

orchagent/pfcactionhandler.cpp


-    attr.id = SAI_BUFFER_PROFILE_ATTR_SHARED_STATIC_TH;
+    attr.id = SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH;
    attr.value.s8 = 0;


dynamic th should -8 which stands for ALPHA_0

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

liat-grozovik · 2022-06-23T21:16:17Z

@neethajohn kindly reminder to review and signoff

orchagent/bufferorch.cpp

…storm is detected (#2304) What I did Avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and does not attach any zero profile to the ingress pg when pfcwd is triggered Revert changes related to #1480 where the retry mechanism was added to BufferOrch which caches the task retries and while the PG is locked by PfcWdZeroBufferHandler. Revert changes related to #2164 in PfcWdZeroBufferHandler & ZeroBufferProfile & BufferOrch. Updated UT's accordingly How I verified it UT's. Ran the sonic-mgmt test with these changes sonic-net/sonic-mgmt#5665 and verified if they've passed. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

…en a PFC storm is detected (#2310) What I did Backport #2304 to 202012 since direct cherry-pick is not possible. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

2022-06-24 93af69c: [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net/sonic-swss#2304) 2022-06-24 37349cf: [swssconfig] Optimize performance of swssconfig (sonic-net/sonic-swss#2336) 2022-06-24 84e9b07: [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net/sonic-swss#2353) 2022-06-24 1b8bd94: Create ACL table fails due to incorrect check for supported ACL actions #11235 (sonic-net/sonic-swss#2351) 2022-06-24 1ed0b4b: [macsec] Refactor the logic of macsec name map (sonic-net/sonic-swss#2348) 2022-06-23 f88f992: [mock_tests] Add Sflow Orch UTs (sonic-net/sonic-swss#2295) 2022-06-23 ec57bf1: [macsec] Update macsec flex counter (sonic-net/sonic-swss#2338) 2022-06-22 6e0fc85: [ACL] Support stage particular match fields (sonic-net/sonic-swss#2341) 2022-06-22 efb4530: [orchagent, DTel]: report session support to set user vrf (sonic-net/sonic-swss#2326) 2022-06-22 d82874d: Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig #11046" (sonic-net/sonic-swss#2332) 2022-06-22 0c789e6: Fix qos map test in vs test (sonic-net/sonic-swss#2343) 2022-06-17 1bb5070: Enhance mock test for dynamic buffer manager for port removing and qos reload flows (sonic-net/sonic-swss#2262) 2022-06-16 700492f: [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net/sonic-swss#2155)

…storm is detected (sonic-net#2304) What I did Avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and does not attach any zero profile to the ingress pg when pfcwd is triggered Revert changes related to sonic-net#1480 where the retry mechanism was added to BufferOrch which caches the task retries and while the PG is locked by PfcWdZeroBufferHandler. Revert changes related to sonic-net#2164 in PfcWdZeroBufferHandler & ZeroBufferProfile & BufferOrch. Updated UT's accordingly How I verified it UT's. Ran the sonic-mgmt test with these changes sonic-net/sonic-mgmt#5665 and verified if they've passed. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

vivekrnv and others added 4 commits May 19, 2022 05:49

PfcWdZeroBufferHandler only applies zero buffer profile on egress queue

748bdaf

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Merge branch 'Azure:master' into pfc_pg

1ae35ab

Test Updated

7702108

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Merge branch 'pfc_pg' of https://github.com/vivekreddynv/sonic-swss i…

6f449cd

…nto pfc_pg

vivekrnv requested review from neethajohn and prsunny as code owners June 1, 2022 17:08

stephenxs previously approved these changes Jun 2, 2022

View reviewed changes

vivekrnv mentioned this pull request Jun 3, 2022

[PFC_WD] [202012] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected #2310

Merged

prsunny mentioned this pull request Jun 9, 2022

Don't query buffer profile attributes before APPLY_VIEW #2231

Open

dgsudharsan added the Request for 202205 Branch label Jun 14, 2022

vivekrnv and others added 3 commits June 14, 2022 13:59

Merge branch 'Azure:master' into pfc_pg

7dd0e2d

Removed the bufferorch's ability to cache previousy created pool's an…

ed7b28c

…d profies Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Updated the ZeroBufferHandler UT to the new design

1e485cc

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

vivekrnv dismissed stephenxs’s stale review via 1e485cc June 18, 2022 03:09

Merge branch 'Azure:master' into pfc_pg

49cd8b1

stephenxs reviewed Jun 22, 2022

View reviewed changes

vivekrnv added 2 commits June 22, 2022 06:01

Comment handled

9c25179

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Merge branch 'pfc_pg' of https://github.com/vivekreddynv/sonic-swss i…

c97c25c

…nto pfc_pg

stephenxs reviewed Jun 22, 2022

View reviewed changes

Update dynamic_th

4e821bf

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

stephenxs approved these changes Jun 22, 2022

View reviewed changes

neethajohn reviewed Jun 23, 2022

View reviewed changes

orchagent/bufferorch.cpp Show resolved Hide resolved

neethajohn approved these changes Jun 24, 2022

View reviewed changes

neethajohn merged commit 93af69c into sonic-net:master Jun 24, 2022

neethajohn added the Request for 202111 Branch label Jun 24, 2022

vivekrnv deleted the pfc_pg branch June 24, 2022 18:40

yxieca added the Included in 202205 Branch label Jun 25, 2022

jimmyzhai mentioned this pull request Jun 26, 2022

[submodule]: update sonic-swss sonic-net/sonic-buildimage#11260

Merged

7 tasks

dgsudharsan mentioned this pull request Oct 12, 2022

[202111] [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected #2402

Closed

meinh mentioned this pull request Jul 26, 2023

[pfcwd] Adding innovium to the list of platforms for forward action sonic-net/sonic-mgmt#9119

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected#2304

[PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected#2304
neethajohn merged 11 commits intosonic-net:masterfrom
vivekrnv:pfc_pg

vivekrnv commented Jun 1, 2022 •

edited

Loading

Uh oh!

vivekrnv commented Jun 11, 2022

Uh oh!

mssonicbld commented Jun 11, 2022

Uh oh!

azure-pipelines bot commented Jun 11, 2022

Uh oh!

stephenxs Jun 22, 2022

Uh oh!

stephenxs Jun 22, 2022

Uh oh!

liat-grozovik commented Jun 23, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

vivekrnv commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vivekrnv commented Jun 11, 2022

Uh oh!

mssonicbld commented Jun 11, 2022

Uh oh!

azure-pipelines bot commented Jun 11, 2022

Uh oh!

stephenxs Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

stephenxs Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

liat-grozovik commented Jun 23, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vivekrnv commented Jun 1, 2022 •

edited

Loading