Skip to content

[counter] Support gearbox counters#2218

Merged
jimmyzhai merged 8 commits intosonic-net:masterfrom
jimmyzhai:gearbox
May 28, 2022
Merged

[counter] Support gearbox counters#2218
jimmyzhai merged 8 commits intosonic-net:masterfrom
jimmyzhai:gearbox

Conversation

@jimmyzhai
Copy link
Contributor

@jimmyzhai jimmyzhai commented Apr 2, 2022

What I did
1/ Enable gearbox port counter collection in GB_COUNTERS_DB
2/ Enable gearbox macsec counter collection in GB_COUNTERS_DB

Why I did it
Support the missing features of gearbox port and macsec counter

How I verified it

  1. Gearbox port counters:
admin@DUT:~$ redis-cli -n 10 hget "COUNTERS_PORT_NAME_MAP" Ethernet112_system
"oid:0x701010000000031"
admin@DUT:~$ redis-cli -n 10 hget "COUNTERS_PORT_NAME_MAP" Ethernet112_line
"oid:0x701010000000032"
admin@DUT:~$ redis-cli -n 10 hgetall "COUNTERS:oid:0x701010000000031"
 1) "SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES"
 2) "0"
 3) "SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS"
 4) "0"
 5) "SAI_PORT_STAT_ETHER_STATS_JABBERS"
 6) "0"
 7) "SAI_PORT_STAT_ETHER_STATS_UNDERSIZE_PKTS"
 8) "0"
 9) "SAI_PORT_STAT_IF_OUT_DISCARDS"
10) "0"
11) "SAI_PORT_STAT_ETHER_STATS_FRAGMENTS"
12) "0"
13) "SAI_PORT_STAT_ETHER_RX_OVERSIZE_PKTS"
14) "0"
15) "SAI_PORT_STAT_IF_IN_DISCARDS"
16) "0"
17) "SAI_PORT_STAT_IF_OUT_ERRORS"
18) "0"
19) "SAI_PORT_STAT_IF_IN_ERRORS"
20) "0"
admin@DUT:~$ redis-cli -n 10 hgetall "COUNTERS:oid:0x701010000000032"
 1) "SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES"
 2) "0"
 3) "SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS"
 4) "1"
 5) "SAI_PORT_STAT_ETHER_STATS_JABBERS"
 6) "0"
 7) "SAI_PORT_STAT_ETHER_STATS_UNDERSIZE_PKTS"
 8) "0"
 9) "SAI_PORT_STAT_IF_OUT_DISCARDS"
10) "0"
11) "SAI_PORT_STAT_ETHER_STATS_FRAGMENTS"
12) "0"
13) "SAI_PORT_STAT_ETHER_RX_OVERSIZE_PKTS"
14) "0"
15) "SAI_PORT_STAT_IF_IN_DISCARDS"
16) "0"
17) "SAI_PORT_STAT_IF_OUT_ERRORS"
18) "0"
19) "SAI_PORT_STAT_IF_IN_ERRORS"
20) "0"
  1. MACsec counters on gearbox:
admin@DUT:~$ redis-cli  -n 2 hgetall COUNTERS_MACSEC_SA_TX_NAME_MAP | grep -1 Ethernet112 | sed '1d' 
Ethernet112:72317127283563820:0
oid:0x75c0100000001d0
admin@DUT:~$ redis-cli  -n 2 hgetall COUNTERS_MACSEC_SA_RX_NAME_MAP | grep -1 Ethernet112 | sed '1d'
Ethernet112:72095710130286970:0
oid:0x75c0100000001d1
admin@DUT:~$ redis-cli -n 10 hgetall COUNTERS:oid:0x75c0100000001d0
 1) "SAI_MACSEC_SA_STAT_OUT_PKTS_ENCRYPTED"
 2) "11963"
 3) "SAI_MACSEC_SA_STAT_OUT_PKTS_PROTECTED"
 4) "0"
 5) "SAI_MACSEC_SA_STAT_OCTETS_ENCRYPTED"
 6) "1570237"
 7) "SAI_MACSEC_SA_STAT_OCTETS_PROTECTED"
 8) "0"
 9) "SAI_MACSEC_SA_ATTR_CURRENT_XPN"
10) "11964"
admin@DUT:~$ redis-cli -n 10 hgetall COUNTERS:oid:0x75c0100000001d1  
 1) "SAI_MACSEC_SA_STAT_IN_PKTS_OK"
 2) "12466"
 3) "SAI_MACSEC_SA_STAT_IN_PKTS_NOT_USING_SA"
 4) "0"
 5) "SAI_MACSEC_SA_STAT_IN_PKTS_UNUSED_SA"
 6) "0"
 7) "SAI_MACSEC_SA_STAT_OCTETS_PROTECTED"
 8) "0"
 9) "SAI_MACSEC_SA_STAT_OCTETS_ENCRYPTED"
10) "1577869"
11) "SAI_MACSEC_SA_STAT_IN_PKTS_UNCHECKED"
12) "0"
13) "SAI_MACSEC_SA_STAT_IN_PKTS_DELAYED"
14) "0"
15) "SAI_MACSEC_SA_STAT_IN_PKTS_NOT_VALID"
16) "0"
17) "SAI_MACSEC_SA_STAT_IN_PKTS_LATE"
18) "0"
19) "SAI_MACSEC_SA_STAT_IN_PKTS_INVALID"
20) "0"
21) "SAI_MACSEC_SA_ATTR_CURRENT_XPN"
22) "74352"

Details if related

@jimmyzhai
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai jimmyzhai marked this pull request as ready for review April 11, 2022 12:35
@jimmyzhai jimmyzhai requested a review from prsunny as a code owner April 11, 2022 12:35
@jimmyzhai jimmyzhai requested a review from lguohan April 11, 2022 12:36
@jimmyzhai jimmyzhai requested a review from kcudnik April 19, 2022 01:32
@jimmyzhai jimmyzhai requested a review from Pterosaur as a code owner April 24, 2022 03:09
@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request fixes 1 alert when merging 107bc08 into 0e5e7ba - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request fixes 1 alert when merging 6e7aeb3 into 4d6fa42 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@jimmyzhai jimmyzhai merged commit 9999dae into sonic-net:master May 28, 2022
yxieca pushed a commit that referenced this pull request Jun 15, 2022
1/ Enable gearbox port counter collection in GB_COUNTERS_DB
2/ Enable gearbox macsec counter collection in GB_COUNTERS_DB
jimmyzhai added a commit to sonic-net/sonic-utilities that referenced this pull request Jun 30, 2022
What I did
To support gearbox port counter in CLI, following sonic-net/sonic-swss#2218 and sonic-net/sonic-swss-common#622.

How I did it
Use swsscommon CounterTable API and PortCounter type, covering different underlying switch architecture, asic-only, asic+gearbox.
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
1/ Enable gearbox port counter collection in GB_COUNTERS_DB
2/ Enable gearbox macsec counter collection in GB_COUNTERS_DB
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this pull request Aug 3, 2023
What I did
To support gearbox port counter in CLI, following sonic-net/sonic-swss#2218 and sonic-net/sonic-swss-common#622.

How I did it
Use swsscommon CounterTable API and PortCounter type, covering different underlying switch architecture, asic-only, asic+gearbox.
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
1/ Enable gearbox port counter collection in GB_COUNTERS_DB
2/ Enable gearbox macsec counter collection in GB_COUNTERS_DB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants