[PBH] Implement Edit Flows#2169
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Mar 30, 2022
Merged
Conversation
Collaborator
Author
|
@anish-n / @kktheballer FYI |
Collaborator
|
@anish-n please review and provide your feedback. |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
d288148 to
d5c6597
Compare
Collaborator
Author
|
@anish-n please have a look |
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
d5c6597 to
203cc43
Compare
Collaborator
Author
|
@anish-n just a kind reminder |
stepanblyschak
previously approved these changes
Mar 18, 2022
Collaborator
Author
|
@anish-n just a kind reminder |
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
203cc43 to
6a77490
Compare
anish-n
reviewed
Mar 23, 2022
anish-n
reviewed
Mar 23, 2022
anish-n
previously approved these changes
Mar 23, 2022
Contributor
anish-n
left a comment
anish-n
left a comment
There was a problem hiding this comment.
Overall looks good to me, just have a few questions which I would like to understand on
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
6a77490 to
6f22fa9
Compare
Collaborator
Author
|
@qiluo-msft / @prsunny the review is done. Please help to merge |
Collaborator
|
@anish-n , can you please sign-off? |
anish-n
approved these changes
Mar 30, 2022
Collaborator
|
@nazariig can you please extend your PR description and also refer to the HLD itself? |
Collaborator
Author
@liat-grozovik the link to HLD is already there and the description has been already updated |
stepanblyschak
approved these changes
Mar 30, 2022
liat-grozovik
approved these changes
Mar 30, 2022
6 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Apr 4, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 7, 2022
In order to include the following commit: 0f06910 [PBH] Implement Edit Flows (sonic-net/sonic-swss#2169) sonic-swss 50d5be2 Make changes to support compiling on Bullseye with GCC 10 (#2216) 0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (#2187) f4ec565 [vlanmgrd] fix use-after-free memory issue (#2211) c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (#2206) 5575935 [neighsyncd] increase neighsyncd timeout (#2209) 0f06910 [PBH] Implement Edit Flows (#2169) 6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197) a55343c [azp]: Set diff coverage threshhold to 80% (#2188) 390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165) c1d47e6 [VNET]Fixing nexthop group delete during route change (#2198) 8941cc0 [BFD]Registering BFD state change callback during session creation (#2202) 680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (#2150) 20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (#2178) 5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (#2200) 7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (#2191) 2bef62b Validate LAG has members before mirror session create (#2130) 1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (#2195) 6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (#2179) Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects.
PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes.
HLD: sonic-net/SONiC#909
What I did
Why I did it
How I verified it
Details if related