Add support for route flow counter#2094
Merged
prsunny merged 17 commits intosonic-net:masterfrom Apr 19, 2022
Merged
Conversation
Junchao-Mellanox
force-pushed
the
route-flow-counter
branch
2 times, most recently
from
c92fe8b to
8e299f3
Compare
Junchao-Mellanox
force-pushed
the
route-flow-counter
branch
from
8e299f3 to
e71c7fe
Compare
Junchao-Mellanox
force-pushed
the
route-flow-counter
branch
from
9e39e72 to
17d152c
Compare
dgsudharsan
requested changes
Jan 28, 2022
dgsudharsan
previously approved these changes
Feb 15, 2022
stephenxs
previously approved these changes
Feb 15, 2022
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
dgsudharsan
previously approved these changes
Apr 6, 2022
prsunny
requested changes
Apr 6, 2022
Conflicts: orchagent/orchdaemon.cpp tests/test_flex_counters.py
dgsudharsan
previously approved these changes
Apr 8, 2022
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Apr 11, 2022
prsunny
previously approved these changes
Apr 13, 2022
prsunny
reviewed
Apr 15, 2022
| dvs.servers[1].runcmd("ip route add default via 10.0.0.2") | ||
| dvs.servers[0].runcmd("ping -c 1 10.0.0.3") | ||
|
|
||
| dvs.runcmd("vtysh -c \"configure terminal\" -c \"ip route 1.1.1.0/24 10.0.0.1\"") |
Collaborator
There was a problem hiding this comment.
Why do we have to change to vtysh? Is the previous approach to write to APP_DB not working?
Collaborator
Author
There was a problem hiding this comment.
Yes, it does not work after some merge/rebase...I guess there is some new changes which introduce more strict check.
Collaborator
Author
|
@prsunny could you please review and sign-off? |
Collaborator
|
as this was prev approved and the changes are due to recent master changes, I assumes we can move forward. @prsunny any objection to merge it? |
prsunny
approved these changes
Apr 19, 2022
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
* Add support for route flow counter
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* Add support for route flow counter
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Add support for route flow counter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#908
Build dependency: sonic-net/sonic-swss-common#576
What I did
Add support for route flow counter
Why I did it
For feature route flow counter
How I verified it
Details if related