Skip to content

create debug_shell_enable config to enable debug shell #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prsunny merged 1 commit into from
Dec 3, 2021
Merged

create debug_shell_enable config to enable debug shell #2060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions orchagent/switchorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const map<string, sai_switch_attr_t> switch_attribute_map =
{"ecmp_hash_seed", SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_SEED},
{"lag_hash_seed", SAI_SWITCH_ATTR_LAG_DEFAULT_HASH_SEED},
{"fdb_aging_time", SAI_SWITCH_ATTR_FDB_AGING_TIME},
{"debug_shell_enable", SAI_SWITCH_ATTR_SWITCH_SHELL_ENABLE},
Copy link
Copy Markdown
Collaborator

@prsunny prsunny Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once enabled, how do you disable?

Copy link
Copy Markdown
Contributor Author

@VenkatCisco VenkatCisco Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a create and set event as per SAI spec.

Copy link
Copy Markdown
Contributor Author

@VenkatCisco VenkatCisco Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/opencomputeproject/SAI/blob/master/inc/saiswitch.h#L1671

Copy link
Copy Markdown

@rameshsanth rameshsanth Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By setting 1 to 0 in below json, the debug shell can be disabled

[
    {
        "SWITCH_TABLE:switch": {
            "debug_shell_enable": "1"
        },
        "OP": "SET"
    }
]

Copy link
Copy Markdown
Collaborator

@prsunny prsunny Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

{"vxlan_port", SAI_SWITCH_ATTR_VXLAN_DEFAULT_PORT},
{"vxlan_router_mac", SAI_SWITCH_ATTR_VXLAN_DEFAULT_ROUTER_MAC}
};
Expand Down Expand Up @@ -344,6 +345,10 @@ void SwitchOrch::doAppSwitchTableTask(Consumer &consumer)
attr.value.u32 = to_uint<uint32_t>(value);
break;

case SAI_SWITCH_ATTR_SWITCH_SHELL_ENABLE:
attr.value.booldata = to_uint<bool>(value);
break;

case SAI_SWITCH_ATTR_VXLAN_DEFAULT_PORT:
attr.value.u16 = to_uint<uint16_t>(value);
break;
Expand Down