[FEC] Enable FEC statistics collection for Ethernet ports#1994
Merged
prgeor merged 1 commit intosonic-net:masterfrom Nov 2, 2021
Merged
[FEC] Enable FEC statistics collection for Ethernet ports#1994prgeor merged 1 commit intosonic-net:masterfrom
prgeor merged 1 commit intosonic-net:masterfrom
Conversation
prsunny
reviewed
Oct 28, 2021
| SAI_PORT_STAT_ETHER_STATS_FRAGMENTS, | ||
| SAI_PORT_STAT_ETHER_STATS_UNDERSIZE_PKTS, | ||
| SAI_PORT_STAT_IP_IN_RECEIVES | ||
| SAI_PORT_STAT_IP_IN_RECEIVES, |
Collaborator
There was a problem hiding this comment.
if the platform/sai does not support this counter, does it throw error or gracefully handled?
Contributor
Author
There was a problem hiding this comment.
Flex counter has a check https://github.com/Azure/sonic-sairedis/blob/master/syncd/FlexCounter.cpp#L200 if counter is supported.
prsunny
approved these changes
Oct 29, 2021
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" (sonic-net#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added FEC correctable, uncorrectable and symbol errors to the list of statistics collected for a port by the flex counter.
Why I did it
To added CLI support to show fec related counters. Currently, Broadcom has enabled fec counters in their SDK.
How I verified it
Ensured the FEC counters are present in counter table:-