Merged
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This was referenced Oct 23, 2021
lguohan
approved these changes
Oct 23, 2021
lguohan
pushed a commit
that referenced
this pull request
Oct 24, 2021
What I did Add secondary COPP config file to enable DHCP V6 (1) need to create a new table, (2) so that the warm reboot asic config checker won't flag it as a configuration change and prevent warm reboot. (3) warm reboot finalizer can selectively just apply the second file. Why I did it Need to enable DHCP V6 How I verified it Warm reboot from a version without it to a version with it. Warm reboot from a version with it to same version. Cold reboot. In all 3 cases, dhcp v6 rules are correctly installed. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Oct 25, 2021
What I did Add secondary COPP config file to enable DHCP V6 Why I did it Need to enable DHCP V6 Create separate file because: - The new COPP rule needs to be in a separate table so that it could applied individually after warm reboot. - The warm reboot has asic config checker, keeping the config in a separate file could avoid the checker flag it as a config change therefore stop warm reboot. - Make it convenient for warm reboot finalizer to apply this config individually. How I verified it Warm reboot from a version without it to a version with it. Warm reboot from a version with it to same version. Cold reboot. In all 3 cases, dhcp v6 rules are correctly installed. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add secondary COPP config file to enable DHCP V6
Why I did it
Need to enable DHCP V6
How I verified it
Warm reboot from a version without it to a version with it.
Warm reboot from a version with it to same version.
Cold reboot.
In all 3 cases, dhcp v6 rules are correctly installed.
Signed-off-by: Ying Xie ying.xie@microsoft.com