Skip to content

[qos] Add EXP to TC map support#1954

Merged
prsunny merged 4 commits intosonic-net:masterfrom
Metaswitch:exp_to_tc
Nov 5, 2021
Merged

[qos] Add EXP to TC map support#1954
prsunny merged 4 commits intosonic-net:masterfrom
Metaswitch:exp_to_tc

Conversation

@TACappleman
Copy link
Contributor

@TACappleman TACappleman commented Oct 12, 2021

What I did
Added EXP to TC map support, matching existing DSCP to TC map

Why I did it
Further support for MPLS functionality

How I verified it
New unit test

Details if related

@TACappleman TACappleman requested a review from prsunny as a code owner October 12, 2021 14:22
@TACappleman
Copy link
Contributor Author

TACappleman commented Oct 12, 2021

HLD: sonic-net/SONiC#844

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2021

This pull request introduces 1 alert when merging 22511b8 into ef6b5d4 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@TACappleman
Copy link
Contributor Author

TACappleman commented Oct 12, 2021

Has dependency on sonic-net/sonic-swss-common#537, so not expected to build yet

@TACappleman TACappleman mentioned this pull request Oct 19, 2021
Merged
@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2021

This pull request introduces 1 alert when merging 3d47662 into d95823d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request fixes 3 alerts when merging 441dce0 into ac3103a - view on LGTM.com

fixed alerts:

  • 2 for Unused import
  • 1 for Unused local variable

@TACappleman
Copy link
Contributor Author

TACappleman commented Nov 1, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 1, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 1, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Nov 1, 2021

This pull request fixes 3 alerts when merging 017a160 into ac3103a - view on LGTM.com

fixed alerts:

  • 2 for Unused import
  • 1 for Unused local variable

@rlhui rlhui requested a review from abdosi November 2, 2021 17:39
@TACappleman
Copy link
Contributor Author

TACappleman commented Nov 2, 2021

@abdosi can you review this PR? (The pipeline is failing due to an infrastructure issue which is hopefully being resolved)

@TACappleman
Copy link
Contributor Author

TACappleman commented Nov 3, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 3, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request fixes 3 alerts when merging 5329aae into 8261c1f - view on LGTM.com

fixed alerts:

  • 2 for Unused import
  • 1 for Unused local variable

@TACappleman
Copy link
Contributor Author

TACappleman commented Nov 4, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 4, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

abdosi
abdosi approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TACappleman
Copy link
Contributor Author

TACappleman commented Nov 5, 2021

@abdosi or @prsunny can you merge this PR please?

@prsunny prsunny merged commit e14a071 into sonic-net:master Nov 5, 2021
@abanu-ms abanu-ms deleted the exp_to_tc branch November 26, 2021 10:48
TACappleman added a commit to Metaswitch/sonic-swss that referenced this pull request Dec 13, 2021
@TACappleman
[qos] Add EXP to TC map support (sonic-net#1954)
5790084 
* [Mpls/qos] Add EXP to TC map support
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@TACappleman
[qos] Add EXP to TC map support (sonic-net#1954)
a49f651 
* [Mpls/qos] Add EXP to TC map support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abdosi abdosi abdosi approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TACappleman @mssonicbld @abdosi @prsunny @abanu-ms