Skip to content

[orchagent] NVGRE Tunnel orchestration agent implementation#1953

Merged
liat-grozovik merged 35 commits intosonic-net:masterfrom
vadymhlushko-mlnx:nvgre_tunnel
Mar 15, 2022
Merged

[orchagent] NVGRE Tunnel orchestration agent implementation#1953
liat-grozovik merged 35 commits intosonic-net:masterfrom
vadymhlushko-mlnx:nvgre_tunnel

Conversation

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Oct 12, 2021 •
edited
Loading

DEPENDS ON:
sonic-swss-common/pull/549

What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

Why I did it

How I verified it
Implemented VS test.

Details if related

@vadymhlushko-mlnx vadymhlushko-mlnx changed the title Nvgre tunnel NVGRE Tunnel orchestration agent implementation Oct 12, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx mentioned this pull request Oct 12, 2021
Merged
@caizhenghui-juniper
Copy link
Copy Markdown
Contributor

caizhenghui-juniper commented Oct 12, 2021

Is there no dstIP? how do we setup encap of traffic through the tunnel?

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Oct 17, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 17, 2021

Azure Pipelines successfully started running 1 pipeline(s).

vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
vadymhlushko-mlnx
vadymhlushko-mlnx commented Oct 26, 2021
View reviewed changes
@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as ready for review October 29, 2021 10:38
@vadymhlushko-mlnx vadymhlushko-mlnx changed the title NVGRE Tunnel orchestration agent implementation [orchagent] NVGRE Tunnel orchestration agent implementation Oct 29, 2021
@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 1, 2021

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Nov 1, 2021

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 1, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 15, 2021

@@kperumalbfn could you please help to review?
@vadymhlushko-mlnx please handle conflicts as soon as you can.

@kperumalbfn
Copy link
Copy Markdown
Contributor

kperumalbfn commented Nov 16, 2021

@liat-grozovik @mickeyspiegel is reviewing NVGRE tunnel PRs

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 18, 2021

@mickeyspiegel, kind reminder, could you please help to review this PR

mickeyspiegel
mickeyspiegel reviewed Nov 19, 2021
View reviewed changes
@vadymhlushko-mlnx
Draft version of nvgre tunnel
6f4bfc0 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
Compiled
1db8139 
Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Dec 21, 2021

Is there no dstIP? how do we setup encap of traffic through the tunnel?

Currently, we add implementation only for the decap flow and it is L2 over L3 tunnel, so it should not be referenced by route objects. So at this point, you will be able to configure tunnel object and mapper entries for decap. This covers exactly the same use case as we have for L2 VXLAN, for example, please take a look at this test - test_vxlan_decap.py

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Jan 2, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 2, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Jan 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Jan 26, 2022

@mickeyspiegel could you please review recent changes following your feedback? if not more comments we will merge this PR

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Feb 21, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 21, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 21, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Feb 24, 2022

/azp run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Feb 28, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 28, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 28, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Mar 3, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Mar 3, 2022

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Mar 8, 2022 •
edited
Loading

@liat-grozovik
LGMT analysis failed not because of this PR.
LGTM analysis failed because it found minor (mostly code style) issues in already existing code in the sonic-swss submodule.

@liat-grozovik liat-grozovik merged commit 0294376 into sonic-net:master Mar 15, 2022
dprital pushed a commit to dprital/sonic-swss that referenced this pull request May 8, 2022
@vadymhlushko-mlnx @dprital
[orchagent] NVGRE Tunnel orchestration agent implementation (sonic-ne…
43a3424 
…t#1953)

- What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

- Why I did it
Part of the NVGRE feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Vadym Hlushko <[email protected]>
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
@vadymhlushko-mlnx @preetham-singh
[orchagent] NVGRE Tunnel orchestration agent implementation (sonic-ne…
4c2fef7 
…t#1953)

- What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

- Why I did it
Part of the NVGRE feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Vadym Hlushko <[email protected]>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@vadymhlushko-mlnx
[orchagent] NVGRE Tunnel orchestration agent implementation (sonic-ne…
625f804 
…t#1953)

- What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

- Why I did it
Part of the NVGRE feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Vadym Hlushko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volodymyrsamotiy volodymyrsamotiy volodymyrsamotiy approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

+1 more reviewer

@mickeyspiegel mickeyspiegel mickeyspiegel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vadymhlushko-mlnx @caizhenghui-juniper @liat-grozovik @mssonicbld @kperumalbfn @volodymyrsamotiy @mickeyspiegel