[Dynamic buffer] [Mellanox] Calculate the peer response time according to the speed#1930
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Nov 15, 2021
Merged
Conversation
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
stephenxs
approved these changes
Sep 24, 2021
Collaborator
|
@neethajohn kindly reminder. can you please review? |
Collaborator
|
@neethajohn kindly reminder. this part should go to 202111 and we need to close it soon. |
neethajohn
approved these changes
Nov 11, 2021
keboliu
changed the title
5 tasks
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…g to the speed (sonic-net#1930) - What I did Peer response time was deduced from a fixed value for all the ports speed. According to IEEE802.3 31B.3.7 at different operating speeds, the peer response time is also different, to have a more accurate headroom allocation, the way to calculate the peer response time shall be changed accordingly. See HLD update PR sonic-net/SONiC#870 for more info - Why I did it To have the peer response time more accurate, calculate according to the definition in IEEE802.3 31B.3.7 - How I verified it Run buffer regression tests on various Mellanox platforms at various port speeds, cable lengths, with or w/o gearbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
What I did
Peer response time was deduced from a fixed value for all the ports speed. According to IEEE802.3 31B.3.7 at different operating speeds, the peer response time is also different, to have a more accurate headroom allocation, the way to calculate the peer response time shall be changed accordingly. See HLD update PR sonic-net/SONiC#870 for more info
Why I did it
To have the peer response time more accurate, calculate according to the definition in IEEE802.3 31B.3.7
How I verified it
Run buffer regression tests on various Mellanox platforms at various port speeds, cable lengths, with or w/o gearbox.
Details if related