Completely remove "recirc port" code#1911
Closed
qiluo-msft wants to merge 2 commits intosonic-net:masterfrom
Closed
Completely remove "recirc port" code#1911qiluo-msft wants to merge 2 commits intosonic-net:masterfrom
qiluo-msft wants to merge 2 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
@ysmanman Could you also help review? |
|
This pull request fixes 2 alerts when merging bb9f17f into 57d21e7 - view on LGTM.com fixed alerts:
|
Collaborator
|
@kcudnik for viz |
prsunny
approved these changes
Sep 16, 2021
Contributor
|
Address lgtm alerts ? also will this be back, since it seems more right to find root cause of this and fix it instead of remove it completely |
Contributor
Author
|
LGTM result is actually positive, fixing 2. |
Contributor
|
Why do we want to revert this change? This will break everflow support. |
Contributor
|
@qiluo-msft why we are reverting ? Idea of PR #1813 was to revert code that was needed when SAI did not have correct support so when SAI has correct support this PR reverted it. |
abdosi
requested changes
Sep 16, 2021
Contributor
abdosi
left a comment
abdosi
left a comment
There was a problem hiding this comment.
Need clarification why PR needs revert ?
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ic-net#1911) * Fixed the NameError issur for CONFIG_FILE Signed-off-by: Vivek Reddy Karri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Completely remove "recirc port" code. The intention of 1813 is to revert 1530, but it is not complete.
Reverts below commits
Why I did it
How I verified it
Details if related