[201911] Add lgtm.yml by stephenxs · Pull Request #1901 · sonic-net/sonic-swss

stephenxs · 2021-09-10T03:42:36Z

What I did
Add LGTM.yml for 201911

Signed-off-by: Stephen Sun [email protected]

Why I did it

How I verified it

Details if related

liat-grozovik · 2021-09-12T13:01:43Z

@xumia do you have additional suggestion how to overcome the lgtm issues in 201911?

stephenxs · 2021-09-18T13:29:39Z

/azpw run

mssonicbld · 2021-09-18T13:29:40Z

/AzurePipelines run

azure-pipelines · 2021-09-18T13:29:50Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-09-18T14:22:39Z

To enable LGTM on 201911 branch, we need to cherry-pick the following PRs to 201911

qiluo-msft · 2021-09-27T10:58:25Z

@abdosi Could you help cherry-pick above 2 PRs to 201911?

abdosi · 2021-10-06T15:48:34Z

@stepanblyschak Above cherr-pick are done. Can you check why it is still failing ?

abdosi · 2021-10-06T16:57:47Z

/azp run

azure-pipelines · 2021-10-06T16:57:57Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-10-08T01:51:10Z

/azpw run

mssonicbld · 2021-10-08T01:51:12Z

/AzurePipelines run

azure-pipelines · 2021-10-08T01:51:22Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-10-08T02:04:10Z

Hi @abdosi
Thanks for cherry-picking them.
From the log I saw this

HEAD is now at 5866b49 lgtm: Merge of c319d569842ca2cf431621e7fe724ad2bffc4a8a into cccb59efa031b817c1936a74db969debbb9b2775

The commit cccb59ef is still the one before cherry-picking. is it because the submodule isn't updated?

abdosi · 2021-10-08T02:12:07Z

check now. I have update submodule.

stephenxs · 2021-10-08T02:14:48Z

/azpw run

mssonicbld · 2021-10-08T02:14:50Z

/AzurePipelines run

azure-pipelines · 2021-10-08T02:14:59Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <[email protected]>

stephenxs · 2021-10-08T02:48:36Z

/azpw run

mssonicbld · 2021-10-08T02:48:37Z

/AzurePipelines run

azure-pipelines · 2021-10-08T02:48:46Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-10-08T02:48:54Z

/azpw run

mssonicbld · 2021-10-08T02:48:55Z

/AzurePipelines run

azure-pipelines · 2021-10-08T02:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-10-08T08:16:53Z

/azpw run

mssonicbld · 2021-10-08T08:16:54Z

/AzurePipelines run

azure-pipelines · 2021-10-08T08:17:04Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <[email protected]>

stephenxs · 2021-10-08T15:45:50Z

Compiling portsorch.cpp failed due to the following error:

void PortsOrch::doTask()
{
    constexpr auto tableOrder = {
        APP_PORT_TABLE_NAME,
        APP_LAG_TABLE_NAME,
        APP_LAG_MEMBER_TABLE_NAME,
        APP_VLAN_TABLE_NAME,
        APP_VLAN_MEMBER_TABLE_NAME,
    };
    ^error: ‘const std::initializer_list<const char*>{((const char* const*)(&<anonymous>)), 5}’ is not a constant expression
    for (auto tableName: tableOrder)
    {
        auto consumer = getExecutor(tableName);
        consumer->drain();
    }

Looks like some flags are not correct.

[2021-10-08 15:13:47] [build-stdout] g++ -DHAVE_CONFIG_H -I. -I.. -I .. -I ../warmrestart -I flex_counter -I debug_counter -g -DNDEBUG  -std=c++14 -Wall -fPIC -Wno-write-strings -I/usr/include/libnl3 -I/usr/include/swss -Werror -Wno-reorder -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winvalid-pch -Wlong-long -Wmissing-field-initializers -Wmissing-format-attribute -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wno-switch-default -Wno-long-long -Wno-redundant-decls -I /usr/include/sai -I/opt/work/lgtm-workspace/usr/include -I/opt/work/lgtm-workspace/usr/include/swss -I/opt/work/lgtm-workspace/usr/include/sai  -g -O2 -MT orchagent-portsorch.o -MD -MP -MF .deps/orchagent-portsorch.Tpo -c -o orchagent-portsorch.o `test -f 'portsorch.cpp' || echo './'`portsorch.cpp
[2021-10-08 15:13:48] [build-stderr] portsorch.cpp: In member function ‘virtual void PortsOrch::doTask()’:
[2021-10-08 15:13:48] [build-stderr] portsorch.cpp:2727:5: error: ‘const std::initializer_list<const char*>{((const char* const*)(&<anonymous>)), 5}’ is not a constant expression
[2021-10-08 15:13:48] [build-stderr]  2727 |     };
[2021-10-08 15:13:48] [build-stderr]       |     ^
[2021-10-08 15:13:56] [build-stderr] make[2]: *** [Makefile:706: orchagent-portsorch.o] Error 1
[2021-10-08 15:13:56] [build-stdout] make[2]: Leaving directory '/opt/src/orchagent'
[2021-10-08 15:13:56] [build-stdout] make[1]: Leaving directory '/opt/src'
[2021-10-08 15:13:56] [build-stderr] make[1]: *** [Makefile:404: all-recursive] Error 1
[2021-10-08 15:13:56] [build-stderr] make: *** [Makefile:336: all] Error 2

stephenxs · 2021-10-08T15:47:38Z

@prsunny can you help to check why this error occurred during LGTM compiling? The error didn't occur if I build it in slave docker.

Signed-off-by: stephens <[email protected]>

stephenxs · 2021-10-11T02:06:10Z

@prsunny can you help to check why this error occurred during LGTM compiling? The error didn't occur if I build it in slave docker.

This error has been fixed by #1250. We need to cherry-pick it as well.

xumia · 2021-10-11T05:38:00Z

We can still see the LGTM failure in the PR, it will be resolved after the PR merged, because of LGTM failure on branch 201911.

https://lgtm.com/projects/g/Azure/sonic-swss/logs/rev/pr-99c1bbe81ccb8c054a9da6d2eb9795bf89750d08/lang:cpp/stage:Build%20201911_901e2efb4f5c6a1179068b43e6a837dfff19d9d9

Commit fa2c96e is the latest commit.
Commit ac179db is the commit merged to branch 201911, works as expected.
Commit 901e2ef is the latest commit on branch 201911, it does not work, it will work after merging the lgtm configuration.

liat-grozovik · 2021-10-11T05:45:52Z

So, do we merge first the others or merge this one and make the other later in the branch? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: xumia ***@***.***> Sent: Monday, October 11, 2021 8:38:27 AM To: Azure/sonic-swss ***@***.***> Cc: Liat Grozovik ***@***.***>; Comment ***@***.***> Subject: Re: [Azure/sonic-swss] [201911] Add lgtm.yml (#1901) @xumia approved this pull request. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#1901 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA4P4DDKD4ZNKA76HGTUGJZ5HANCNFSM5DYPDIZQ>. Triage notifications on the go with GitHub Mobile for iOS<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cliatg%40nvidia.com%7C67fc776dcd3747b0399408d98c795a00%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637695275096034002%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8gKTMpCpI92QqBzGr4%2F2NYSfs2gOhYh2gSaYEHPxhsU%3D&reserved=0> or Android<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cliatg%40nvidia.com%7C67fc776dcd3747b0399408d98c795a00%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637695275096034002%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lfPpz%2BScZmq0i%2BwbxkuLe74LgtdwwooxrFW4wG4VzfQ%3D&reserved=0>.

To fix LGTM in this PR is for dry run only. It should be done by cherry-picking PR#1250 With portsorch.cpp fixed, dry run passed. This reverts commit fa2c96e.

1) Copy generic_updater_config.conf.json as part of install 2) Read conf file from install dir 3) Drop empty keys & tables upon jsonpatch.JsonPatch.apply to be in sync with redis update 4) Prefix service_validator module path with "generic_updater"

liat-grozovik mentioned this pull request Sep 12, 2021

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

Closed

neethajohn requested a review from xumia September 13, 2021 19:29

stephenxs force-pushed the fix-lgtm branch 2 times, most recently from ab2fc0a to c319d56 Compare September 18, 2021 14:10

stephenxs marked this pull request as ready for review September 18, 2021 14:22

qiluo-msft approved these changes Sep 27, 2021

View reviewed changes

Add lgtm.yml

7bf8d05

Signed-off-by: Stephen Sun <[email protected]>

stephenxs force-pushed the fix-lgtm branch from c319d56 to 7bf8d05 Compare October 8, 2021 02:26

stephenxs added 2 commits October 8, 2021 22:07

Add some missing libs

fe46805

Signed-off-by: Stephen Sun <[email protected]>

Add missing libs

b8010ff

Signed-off-by: Stephen Sun <[email protected]>

Fix LGTM error in portsorch.cpp

fa2c96e

Signed-off-by: stephens <[email protected]>

xumia approved these changes Oct 11, 2021

View reviewed changes

Revert "Fix LGTM error in portsorch.cpp"

014c6e0

To fix LGTM in this PR is for dry run only. It should be done by cherry-picking PR#1250 With portsorch.cpp fixed, dry run passed. This reverts commit fa2c96e.

qiluo-msft merged commit acdb033 into sonic-net:201911 Oct 11, 2021

stephenxs deleted the fix-lgtm branch October 11, 2021 23:03

stephenxs mentioned this pull request Oct 14, 2021

LGTM analysis always fails due to compiling error on 201911 branch #1889

Closed

ayurkiv-nvda mentioned this pull request Jun 8, 2022

[201911] [Flex counters] Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group #2263

Merged

Conversation

stephenxs commented Sep 10, 2021

Uh oh!

liat-grozovik commented Sep 12, 2021

Uh oh!

stephenxs commented Sep 18, 2021

Uh oh!

mssonicbld commented Sep 18, 2021

Uh oh!

azure-pipelines bot commented Sep 18, 2021

Uh oh!

stephenxs commented Sep 18, 2021

Uh oh!

qiluo-msft commented Sep 27, 2021

Uh oh!

abdosi commented Oct 6, 2021

Uh oh!

abdosi commented Oct 6, 2021

Uh oh!

azure-pipelines bot commented Oct 6, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

mssonicbld commented Oct 8, 2021

Uh oh!

azure-pipelines bot commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

abdosi commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

mssonicbld commented Oct 8, 2021

Uh oh!

azure-pipelines bot commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

mssonicbld commented Oct 8, 2021

Uh oh!

azure-pipelines bot commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

mssonicbld commented Oct 8, 2021

Uh oh!

azure-pipelines bot commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

mssonicbld commented Oct 8, 2021

Uh oh!

azure-pipelines bot commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 8, 2021

Uh oh!

stephenxs commented Oct 11, 2021

Uh oh!

xumia commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liat-grozovik commented Oct 11, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xumia commented Oct 11, 2021 •

edited

Loading