[RIF] Change rif_rates.lua script to calculate rates correctly#1848
Merged
prsunny merged 1 commit intosonic-net:masterfrom Aug 18, 2021
Merged
[RIF] Change rif_rates.lua script to calculate rates correctly#1848prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
/azpw run |
87f4465 to
56de582
Compare
Collaborator
|
It will be helpful if you can explain the fix. Like what was the output before and what got changed |
Collaborator
Author
|
@prsunny Done |
prsunny
previously approved these changes
Aug 11, 2021
Collaborator
|
@dgsudharsan to sign-off |
dgsudharsan
previously approved these changes
Aug 12, 2021
56de582 to
90b87cc
Compare
dgsudharsan
approved these changes
Aug 12, 2021
prsunny
approved these changes
Aug 12, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 19, 2021
…rrect (#1848) Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
This was referenced Aug 25, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 26, 2021
In order to include the following commits: d29a49a 2021-08-25 [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net/sonic-swss#1854) 2569ad9 2021-08-25 Fix sFlow sampling-rate and admin-state (sonic-net/sonic-swss#1728) 8908a8f 2021-08-19 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net/sonic-swss#1848) b42c2fb 2021-08-19 [VS Test] Skip flaky tests (sonic-net/sonic-swss#1875)
judyjoseph
pushed a commit
that referenced
this pull request
Aug 26, 2021
…rrect (#1848) Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…rrect (sonic-net#1848) Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…rrect (sonic-net#1848) Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: noaOrMlnx noaor@nvidia.com
What I did
Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
Why I did it
Fix issue - sonic-net/sonic-buildimage#8392
How I verified it
Checked that when sending traffic, the output of 'show interfaces counters rif' and the rates appear in RATES table, counter db are close.
before the change:
Details if related