Skip to content

[pbh]: Add PBH OA#1782

Merged
prsunny merged 2 commits intosonic-net:masterfrom
nazariig:master-pbh
Sep 1, 2021
Merged

[pbh]: Add PBH OA#1782
prsunny merged 2 commits intosonic-net:masterfrom
nazariig:master-pbh

Conversation

@nazariig
Copy link
Collaborator

@nazariig nazariig commented Jun 11, 2021 •
edited
Loading

PBH architecture:

  1. PBH OA
  2. PBH Helper
  3. PBH Container

PBH business logic:

  1. PBH OA: receive the updates from Redis (Config DB)

  2. PBH Helper/PBH Container: parse data/store in internal cache:

    • If no errors observed - store task by table key in internal cache
    • If task with the same key already exists - postpone processing and proceed with the next one
    • Set/Remove tasks are stored in separate maps
    • For each type of Config DB entity (table, rule, hash and hash field) a dedicated PBH container is used

  3. PBH OA: deploy tasks:

    • Use Remove & Setup policy
    • Process create/update (SET) tasks in correct order
    • Do the same for delete (REMOVE) tasks

Why I did it

  • Done as part of PBH development

How I did it

  • Added PBH OA

How to verify it

  1. Add PBH configuration
  2. Run DPB

Which release branch to backport (provide reason below if selected)

  • 202106

Description for the changelog

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig nazariig mentioned this pull request Jun 11, 2021
Merged
prsunny
prsunny reviewed Jun 11, 2021
View reviewed changes
@prsunny
Copy link
Collaborator

prsunny commented Jun 16, 2021

@anish-n to review and sign-off

@nazariig nazariig marked this pull request as ready for review June 18, 2021 11:26
@liat-grozovik liat-grozovik requested a review from prsunny June 21, 2021 16:01
stepanblyschak
stepanblyschak reviewed Jun 25, 2021
View reviewed changes
anish-n
anish-n reviewed Jun 28, 2021
View reviewed changes
anish-n
anish-n reviewed Jun 28, 2021
View reviewed changes
anish-n
anish-n reviewed Jun 28, 2021
View reviewed changes
@prsunny
Copy link
Collaborator

prsunny commented Jul 14, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 14, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@sonic-net sonic-net deleted a comment from nazariig Jul 14, 2021
@sonic-net sonic-net deleted a comment from azure-pipelines bot Jul 14, 2021
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Jul 18, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 18, 2021

Azure Pipelines successfully started running 1 pipeline(s).

prsunny
prsunny reviewed Jul 26, 2021
View reviewed changes
@nazariig
Copy link
Collaborator Author

nazariig commented Jul 27, 2021

@anish-n please review and sign-off

@prsunny prsunny requested a review from bingwang-ms July 27, 2021 19:28
@nazariig
Copy link
Collaborator Author

nazariig commented Jul 28, 2021

@bingwang-ms please review and sign-off

anish-n
anish-n previously approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@anish-n anish-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PBH-wise looks good to me. Please wait for review from Bing on ACLorch and Prince on overall Orchagent prior to merge.

@nazariig
Copy link
Collaborator Author

nazariig commented Jul 30, 2021

@bingwang-ms just a kind reminder

@anshuv-mfst
Copy link

anshuv-mfst commented Aug 3, 2021

Hi @prsunny - could you please review and approve asap, this is needed in 202106 release

bingwang-ms
bingwang-ms reviewed Aug 11, 2021
View reviewed changes
bingwang-ms
bingwang-ms reviewed Aug 11, 2021
View reviewed changes
bingwang-ms
bingwang-ms reviewed Aug 11, 2021
View reviewed changes
@bingwang-ms
Copy link
Contributor

bingwang-ms commented Aug 11, 2021

@bingwang-ms just a kind reminder

Sorry for missing the review. Most part of aclorch looks good to me. Please check the comments I left. Thanks

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 20, 2021

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms
bingwang-ms previously approved these changes Aug 22, 2021
View reviewed changes
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Aug 22, 2021

@anish-n please approve.
@nazariig please check failures. if common lets take with @prsunny

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 23, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 23, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 23, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
[pbh]: Add PBH OA.
5b5a237 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: Fix review comments.
08743a1 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

nazariig commented Aug 23, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 23, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 23, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 24, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 24, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 24, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 25, 2021

@prsunny we have got all the approvals, please review & merge

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 27, 2021

@prsunny just a kind reminder

@nazariig nazariig mentioned this pull request Aug 29, 2021
Merged
5 tasks
@prsunny
Copy link
Collaborator

prsunny commented Aug 31, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 31, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Aug 31, 2021

@anish-n , @bingwang-ms , could you please sign-off?

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 31, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 31, 2021

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 31, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit eb79ca4 into sonic-net:master Sep 1, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
@nazariig @raphaelt-nvidia
[pbh]: Add PBH OA (sonic-net#1782)
812bd5a 
* [pbh]: Add PBH OA.
* [pbh]: Helper and PBH Container

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@nazariig
[pbh]: Add PBH OA (sonic-net#1782)
03a3466 
* [pbh]: Add PBH OA.
* [pbh]: Helper and PBH Container

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stepanblyschak stepanblyschak stepanblyschak left review comments

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

+1 more reviewer

@anish-n anish-n anish-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nazariig @prsunny @liat-grozovik @anshuv-mfst @bingwang-ms @mssonicbld @stepanblyschak @anish-n