[request parser] Allow request parser to parse multiple values#1758
Merged
shi-su merged 1 commit intosonic-net:masterfrom Jun 3, 2021
Merged
[request parser] Allow request parser to parse multiple values#1758shi-su merged 1 commit intosonic-net:masterfrom
shi-su merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jun 2, 2021
Collaborator
|
Can you check tests/request_parser_ut.cpp and add some unit test? |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
sonic-net#1766) What I did Add unit tests for request parser to parse multiple values. Why I did it Add unit tests for the feature added in PR sonic-net#1758. How I verified it Run unit tests locally and confirm the tests pass with the given conditions and constraints.
Contributor
|
Can this be double committed to 202012 branch |
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
sonic-net#1766) What I did Add unit tests for request parser to parse multiple values. Why I did it Add unit tests for the feature added in PR sonic-net#1758. How I verified it Run unit tests locally and confirm the tests pass with the given conditions and constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add an option for request parser to parse strings that contains multiple IP address, MAC address, or unsigned int. Return the values in a vector.
Why I did it
To enable overlay ECMP, the request may contain values with multiple nexthops. This PR aims to properly parse the request in such a scenario.
How I verified it
Details if related