Fix for delay flex counters flow#1739
Fix for delay flex counters flow#1739shlomibitton wants to merge 2 commits intosonic-net:masterfrom shlomibitton:shlomi_fix_delay_counters
Conversation
Signed-off-by: Shlomi Bitton <[email protected]>
liat-grozovik
left a comment
There was a problem hiding this comment.
missing unit test to make sure that when CPU port is the first it is working as expected. so then you can add the original fix which is now expected to be reverted.
|
@qiluo-msft @lguohan Can you please review this? |
|
Could you included previous code into this PR so we can merge this PR atomically? |
@qiluo-msft I created 2 new PR's with the previous code, issue fix and new unit test case for both branches. I am closing this PR since it is not relevant |
Signed-off-by: Shlomi Bitton [email protected]
What I did
Exclude installing flex counter for CPU interface (mgmt) for proper query counter capability.
Fixing this PR: #1646
Why I did it
The CPU interface does not suppose to be inserted to flex counter DB.
In addition, if we query the counter statistics capability by this interface it will cause all port counters id lists to be empty and break lua port rates functionality.
How I verified it
Enable all counters group types and observe all ID lists for ports populated correctly.
Details if related