[sonic-swss] Add port auto negotiation support to swss#1714
[sonic-swss] Add port auto negotiation support to swss#1714jleveque merged 7 commits intosonic-net:masterfrom
Conversation
|
Depends on sonic-net/sonic-buildimage#7361 |
|
Since sonic-net/sonic-buildimage#7361 is merged, could you please help re-triger the test? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @jleveque , I have fixed the vs test issue, could you please kindly review it again? |
|
Fixed conflict |
1. Added port auto negotiation attributes handle 2. Get supported speeds for each port and save them to CONFIG_DB 3. Added new test cases in VS test to verify the change
1. Added port auto negotiation attributes handle 2. Get supported speeds for each port and save them to CONFIG_DB 3. Added new test cases in VS test to verify the change
|
Hi @prsunny @prgeor @lguohan, the following AN feature code violates design of Gearbox port management and it would not be the correct behavior. We have a parent->child relationship in handling ASIC -> PHY ports(system/line) and hence we need to call setPort* APIs. |
|
@prgeor ,can you review |
|
@balanokia , do you've a fix proposal/PR? |
|
hi @prsunny We should comment out the "else part of applying hardcoded speed to GB ports" now to make code clean. For the differential speed configuration as well as discovered speed, GB ports should follow setPortSpeed API. Then AN support for GB ports to be handled as another PR (it has to handle system and line side in sync with ASIC and remote end point). I will make a proposal in upcoming release. Pls share your note. |
|
What I did
Why I did it
To support port auto negotiation feature.
How I verified it
Manual test and vs test
Details if related