[Dynamic buffer calc] Update pool sizes during initialization from timer only#1708
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Apr 27, 2021
Merged
Conversation
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Contributor
|
@stephenxs , can you describe what conditions were missed earlier? I am not clear on what this PR tries to address |
Collaborator
Author
@neethajohn if the port is admin down, it will also try to recalculate the pool size. Description updated. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neethajohn
approved these changes
Apr 27, 2021
liat-grozovik
approved these changes
Apr 27, 2021
daall
pushed a commit
that referenced
this pull request
Apr 29, 2021
- What I did This is a supplement of #1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down. - Why I did it Make sure that the the buffer pools will be updated only once during initialization. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <stephens@nvidia.com>
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 29, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
- What I did This is a supplement of sonic-net#1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down. - Why I did it Make sure that the the buffer pools will be updated only once during initialization. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <stephens@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ic-net#1708) Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> What I did Updated command reference to match fwutil v.2.0.0.0 How I did it Updated command reference
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
- What I did This is a supplement of sonic-net#1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down. - Why I did it Make sure that the the buffer pools will be updated only once during initialization. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <stephens@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is a supplement of #1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down.
In this PR, we will make sure that the buffer pools will be updated only once during initialization.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I verified it
Run regression and manual test
Details if related