[Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation#1706
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Apr 15, 2021
Conversation
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
fix-mgmt-pool
branch
from
52bd710 to
fade365
Compare
stephenxs
changed the title
stephenxs
changed the title
neethajohn
approved these changes
Apr 13, 2021
liat-grozovik
approved these changes
Apr 15, 2021
daall
pushed a commit
that referenced
this pull request
Apr 21, 2021
…buffer pool size calculation (#1706) To calculate the buffer pool size, we need to accumulate all reserved memory and than subtract the sum from total available memory. In the current implementation, one part hasn’t been added to reserved memory, which causes the buffer pool size larger than it should be. To fix it, we need to add it to reserved memory. - What I did Fix buffer over subscription in the buffer pool calculation. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <[email protected]>
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…buffer pool size calculation (sonic-net#1706) To calculate the buffer pool size, we need to accumulate all reserved memory and than subtract the sum from total available memory. In the current implementation, one part hasn’t been added to reserved memory, which causes the buffer pool size larger than it should be. To fix it, we need to add it to reserved memory. - What I did Fix buffer over subscription in the buffer pool calculation. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…et#1706) - What I did Remove redundant mellanox dumps now that Mellanox SAI is taking care of that. - How I did it Deleted the part related to mstdumps from the generate_script - How to verify it Run 'show techsupport' see we no have mstdump folder but the actual dump available under the saisdk dump
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…buffer pool size calculation (sonic-net#1706) To calculate the buffer pool size, we need to accumulate all reserved memory and than subtract the sum from total available memory. In the current implementation, one part hasn’t been added to reserved memory, which causes the buffer pool size larger than it should be. To fix it, we need to add it to reserved memory. - What I did Fix buffer over subscription in the buffer pool calculation. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix buffer over subscription in the buffer pool calculation.
Signed-off-by: Stephen Sun [email protected]
Why I did it
How I verified it
Run regression and manual test
Details if related
To calculate the buffer pool size, we need to accumulate all reserved memory and than subtract the sum from total available memory. In the current implementation, one part hasn’t been added to reserved memory, which causes the buffer pool size larger than it should be.
To fix it, we need to add it to reserved memory.