Skip to content

Allowing the first time FEC and AN configuration to be pushed to SAI#1705

Merged
jleveque merged 3 commits intosonic-net:masterfrom
dgsudharsan:an_fec_lt
Apr 15, 2021
Merged

Allowing the first time FEC and AN configuration to be pushed to SAI#1705
jleveque merged 3 commits intosonic-net:masterfrom
dgsudharsan:an_fec_lt

Conversation

@dgsudharsan
Copy link
Collaborator

@dgsudharsan dgsudharsan commented Apr 13, 2021

What I did
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

Why I did it
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.

How I verified it
Configure FEC as none and autoneg as false and check if ASIC DB is programmed.

Details if related
This change will force the FEC and autoneg configuration only if the configuration is explicitly present. There is no impact when there are no external FEC or autoneg configuration.
If an external FEC or autoneg config is present below are how different boot scenarios will be handled.

  1. Warm boot will not be affected even if an external configuration is present since it will be reconciled. I tested the case and found no link flaps
  2. Fast boot and Cold boot - Only if external configuration is present, it will be programmed during port initialization. No additional link flaps is seen or additional time is taken.

@dgsudharsan
Copy link
Collaborator Author

dgsudharsan commented Apr 13, 2021

This needs to be back ported to 202012

@lguohan lguohan requested a review from jleveque April 13, 2021 20:01
@lguohan
Copy link
Contributor

lguohan commented Apr 13, 2021

can you check the test failure, it seems related to the auto neg feature.

@jleveque
Copy link
Contributor

jleveque commented Apr 13, 2021

This needs to be back ported to 202012

@dgsudharsan: FYI, the autoneg values have changed to on/off in master, but they are still 0/1 in 202012. Therefore, you will need to open a separate PR against 202012 once this is reviewed/merged.

@dgsudharsan
Copy link
Collaborator Author

dgsudharsan commented Apr 13, 2021

This needs to be back ported to 202012

@dgsudharsan: FYI, the autoneg values have changed to on/off in master, but they are still 0/1 in 202012. Therefore, you will need to open a separate PR against 202012 once this is reviewed/merged.

Sure Joe. I will raise a separate PR after this.

@jleveque
Copy link
Contributor

jleveque commented Apr 14, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 14, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque jleveque merged commit 8bc7aee into sonic-net:master Apr 15, 2021
@dgsudharsan dgsudharsan mentioned this pull request Apr 15, 2021
Merged
jleveque pushed a commit that referenced this pull request Apr 16, 2021
@dgsudharsan
[202012] Allowing the first time FEC and AN configuration to be pushe…
0ad524b 
…d to SAI (#1710)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.

This is the porting of PR #1705 to 202012
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
@dgsudharsan @raphaelt-nvidia
Allowing the first time FEC and AN configuration to be pushed to SAI (s…
8c9a8a3 
…onic-net#1705)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@Blueve
[minigraph][port_config] Consume port_config.json while reloading min…
866d1d7 
…igraph (sonic-net#1705)

Signed-off-by: Jing Kan jika@microsoft.com
dgsudharsan added a commit to dgsudharsan/sonic-swss that referenced this pull request Mar 17, 2022
@dgsudharsan
Allowing the first time FEC and AN configuration to be pushed to SAI (s…
d1019a2 
…onic-net#1705)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
dgsudharsan added a commit to dgsudharsan/sonic-swss that referenced this pull request Mar 17, 2022
@dgsudharsan
Allowing the first time FEC and AN configuration to be pushed to SAI (s…
ce39f40 
…onic-net#1705)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
dgsudharsan added a commit to dgsudharsan/sonic-swss that referenced this pull request Mar 17, 2022
@dgsudharsan
Allowing the first time FEC and AN configuration to be pushed to SAI (s…
625b038 
…onic-net#1705)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
@dgsudharsan dgsudharsan mentioned this pull request Mar 24, 2022
Merged
prsunny pushed a commit that referenced this pull request Mar 31, 2022
@dgsudharsan
Allowing the first time FEC and AN configuration to be pushed to SAI (#…
1c12a40 
…1705) (#2196)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
@dgsudharsan dgsudharsan deleted the an_fec_lt branch March 9, 2023 02:00
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@dgsudharsan
Allowing the first time FEC and AN configuration to be pushed to SAI (s…
dbb3414 
…onic-net#1705)

**What I did**
Allowing the first time configuration for FEC and Autoneg to be pushed to SAI even if they are default.

**Why I did it**
In orchagent, the port struct is pre-initialized with fec = none and autoneg = false (Default SAI values). However in different hardware the underlying implementation might be different. There can also be requirement where the user values need to be forced. In current logic due to the port struct being initialized with default, fec = none or an = false configurations are not pushed from orchagent to SAI. In order to push it even in default case the conditional checks are modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgsudharsan @lguohan @jleveque