[buffermgr] Support maximum port headroom checking#1607
Merged
neethajohn merged 2 commits intosonic-net:masterfrom Feb 7, 2021
Merged
[buffermgr] Support maximum port headroom checking#1607neethajohn merged 2 commits intosonic-net:masterfrom
neethajohn merged 2 commits intosonic-net:masterfrom
Conversation
- Fetch the maximum port headroom when the orchagent starts and push the data into STATE_DB - Check the accumulative port headroom against the maximum headroom in buffer_check_headroom_<vendor>.lua Signed-off-by: Stephen Sun <[email protected]>
Collaborator
|
@stephenxs I believe this need to be merged only after Mellanox SAI 1.18.1.0 is merged. If so, can you please connect it to the PR? |
Collaborator
|
@neethajohn can you please review? |
neethajohn
reviewed
Jan 26, 2021
Signed-off-by: Stephen Sun <[email protected]>
Collaborator
Author
Done |
neethajohn
approved these changes
Jan 27, 2021
liat-grozovik
approved these changes
Jan 31, 2021
Collaborator
|
@daall can you please add 202012 label? |
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2021
* Support maximum port headroom checking - Fetch the maximum port headroom via fetching the port attribute SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZE when the orchagent starts and push the data into STATE_DB - Check the accumulative port headroom against the maximum headroom in buffer_check_headroom_<vendor>.lua On Mellanox platform, this PR depends on PR #6566 to be merged. In that PR the required SAI attribute is supported. On other platforms, there is no dependency. Signed-off-by: Stephen Sun [email protected] Why I did it On some platforms, the SAI will notify orchagent shut down if a headroom size that causes the accumulative port headroom to exceed its limit is programmed to SAI. To avoid that, we need to check this before programming it to SAI. How I verified it Run the regression test.
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
* Support maximum port headroom checking - Fetch the maximum port headroom via fetching the port attribute SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZE when the orchagent starts and push the data into STATE_DB - Check the accumulative port headroom against the maximum headroom in buffer_check_headroom_<vendor>.lua On Mellanox platform, this PR depends on PR #6566 to be merged. In that PR the required SAI attribute is supported. On other platforms, there is no dependency. Signed-off-by: Stephen Sun [email protected] Why I did it On some platforms, the SAI will notify orchagent shut down if a headroom size that causes the accumulative port headroom to exceed its limit is programmed to SAI. To avoid that, we need to check this before programming it to SAI. How I verified it Run the regression test.
prsunny
added a commit
that referenced
this pull request
Mar 21, 2021
daall
pushed a commit
that referenced
this pull request
Mar 22, 2021
prsunny
added a commit
that referenced
this pull request
Mar 25, 2021
prsunny
added a commit
that referenced
this pull request
Mar 26, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Support maximum port headroom checking - Fetch the maximum port headroom via fetching the port attribute SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZE when the orchagent starts and push the data into STATE_DB - Check the accumulative port headroom against the maximum headroom in buffer_check_headroom_<vendor>.lua On Mellanox platform, this PR depends on PR #6566 to be merged. In that PR the required SAI attribute is supported. On other platforms, there is no dependency. Signed-off-by: Stephen Sun [email protected] Why I did it On some platforms, the SAI will notify orchagent shut down if a headroom size that causes the accumulative port headroom to exceed its limit is programmed to SAI. To avoid that, we need to check this before programming it to SAI. How I verified it Run the regression test.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…#1607)" (sonic-net#1675) This reverts commit 189a964.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…onic-net#1607)" (sonic-net#1675)" (sonic-net#1682) This reverts commit acfcb85 effectively re-merging sonic-net#1607
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…forms (sonic-net#1607) What I did Skip sonic package migration on aboot platform. How I did it Added a warning and skip the migration. How to verify it I changed AbootBootloader to OnieInstallerBootloader to test on my Onie device. I don't have Aboot device.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Support maximum port headroom checking - Fetch the maximum port headroom via fetching the port attribute SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZE when the orchagent starts and push the data into STATE_DB - Check the accumulative port headroom against the maximum headroom in buffer_check_headroom_<vendor>.lua On Mellanox platform, this PR depends on PR #6566 to be merged. In that PR the required SAI attribute is supported. On other platforms, there is no dependency. Signed-off-by: Stephen Sun [email protected] Why I did it On some platforms, the SAI will notify orchagent shut down if a headroom size that causes the accumulative port headroom to exceed its limit is programmed to SAI. To avoid that, we need to check this before programming it to SAI. How I verified it Run the regression test.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…#1607)" (sonic-net#1675) This reverts commit 189a964.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…onic-net#1607)" (sonic-net#1675)" (sonic-net#1682) This reverts commit acfcb85 effectively re-merging sonic-net#1607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Check the accumulative port headroom against the port's maximum headroom
On Mellanox platform, this PR depends on PR #6566 to be merged. In that PR the required SAI attribute is supported.
On other platforms, there is no dependency.
Signed-off-by: Stephen Sun [email protected]
Why I did it
On some platforms, the SAI will notify orchagent shut down if a headroom size that causes the accumulative port headroom to exceed its limit is programmed to SAI.
To avoid that, we need to check this before programming it to SAI.
How I verified it
Run the regression test.
Details if related
SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZEwhen the orchagent starts and push the data into STATE_DB- Which release branch to backport (provide reason below if selected)