Skip to content

[everflow] Add retry mechanism for mirror sessions and policers#1486

Merged
daall merged 11 commits intosonic-net:masterfrom
daall:fix_everflow_boot_up_sequence
Dec 10, 2020
Merged

[everflow] Add retry mechanism for mirror sessions and policers#1486
daall merged 11 commits intosonic-net:masterfrom
daall:fix_everflow_boot_up_sequence

Conversation

@daall
Copy link
Contributor

@daall daall commented Oct 27, 2020

Signed-off-by: Danny Allen [email protected]

What I did
I added retry mechanisms to AclOrch for mirror sessions and MirrorOrch for policers.

Why I did it
Fixes sonic-net/sonic-buildimage#5497

How I verified it
Tested on a DUT locally. THIS STILL NEEDS VS TESTS AS WELL.

Details if related
This will not cherry-pick cleanly to 201911 b/c of the port mirroring feature, so I will open a separate PR for 201911 once this one is reviewed + merged.

In draft while I finish the VS tests.

@daall daall force-pushed the fix_everflow_boot_up_sequence branch from b628f35 to 6170932 Compare November 6, 2020 20:59
@daall daall marked this pull request as ready for review November 6, 2020 20:59
@yxieca
Copy link
Contributor

yxieca commented Nov 13, 2020

retest vs please

@daall daall force-pushed the fix_everflow_boot_up_sequence branch from a754849 to d57e6ca Compare December 7, 2020 23:50
@daall daall requested a review from qiluo-msft December 7, 2020 23:52
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue added.

@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

LGTM pull request analysis was skipped for 18dbf8b by daall. Analysis of future commits will happen as normal.

@daall daall merged commit b7e4410 into sonic-net:master Dec 10, 2020
@daall daall deleted the fix_everflow_boot_up_sequence branch December 10, 2020 23:21
arlakshm pushed a commit to arlakshm/sonic-swss that referenced this pull request Dec 15, 2020
…c-net#1486)

Signed-off-by: Danny Allen <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…et#1486)

Signed-off-by: Yong Zhao [email protected]

What I did
If the rebooting of SONiC device was caused by kernel panic, then the CLI command show reboot-cause should show Kernel Panic.

How I did it
Currently if kernel was panicked, then the device would be rebooted. The reboot script wrote a message into reboot-cause.txt. I just updated the content of this message.

How to verify it
I verified this change on the virtual switch in the following steps:

Trigger kernel panic: echo c > /proc/sysrq-trigger
After device was rebooted, run the CLI show reboot-cause:
admin@vlab-01:~$ show reboot-cause
Kernel Panic [Time: Tue 09 Mar 2021 03:03:56 AM UTC]
Previous command output (if the output of a command-line utility has changed)
admin@vlab-01:~$ show reboot-cause
User issued 'kdump' command [User: kdump, Time: Mon 08 Mar 2021 01:47:43 AM UTC]

New command output (if the output of a command-line utility has changed)
admin@vlab-01:~$ show reboot-cause
Kernel Panic [Time: Tue 09 Mar 2021 03:03:56 AM UTC]
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mirroring] mirror rule fails to apply after warm reboot

4 participants