Use vlan-mac for Vlan interfaces if specified in VLAN table#1472
Merged
prsunny merged 1 commit intosonic-net:masterfrom Oct 22, 2020
Merged
Use vlan-mac for Vlan interfaces if specified in VLAN table#1472prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
lguohan
approved these changes
Oct 21, 2020
tahmed-dev
approved these changes
Oct 21, 2020
Collaborator
Author
|
retest vs image |
theasianpianist
approved these changes
Oct 21, 2020
Contributor
|
Why not choose to put it as a field in |
Collaborator
Author
VLAN_INTERFACE is handled by intfmgr and not vlanmgr. We would want this to be handled by Vlanmgr. Also similar to mtu, mac also is a layer 2 property while creating interface in kernel by Vlanmgr. That was the rationale. |
Collaborator
Author
|
retest vs please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Added platform pre check support in reboot script. Checking platform based changes before stopping dockers and sonic services. Porting changes in master from 201911 branch sonic-net#1472 How I did it On branch reboot_pre_check_master Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git checkout -- ..." to discard changes in working directory) modified: scripts/reboot How to verify it Write a platform pre check script(platform_reboot_pre_check) and place it in /usr/share/sonic/device// directory. If the script exit with status 0, reboot will be proceeded. If script exit with non-zero status, the reboot script gets stopped.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Use vlan-mac if specified in Config DB Vlan table
Why I did it
How I verified it
Test:
Details if related