[sonic-swsss] Fix the issue of field "next_hop_ip" not getting updated in state DB in ERSPAN Mirror#1375
Merged
abdosi merged 7 commits intosonic-net:masterfrom Aug 19, 2020
Merged
Conversation
daall
previously approved these changes
Aug 3, 2020
Contributor
daall
left a comment
daall
left a comment
There was a problem hiding this comment.
one minor change, overall LGTM. thanks!
daall
previously approved these changes
Aug 7, 2020
Contributor
Author
|
retest this please |
4 similar comments
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
abdosi
force-pushed
the
mirror_state_db_fix
branch
from
b4c0390 to
76cb79c
Compare
Contributor
Author
|
@daall Thanks for debug. Updated mirror library to use wait_for_field_match instead of wait_for_entry |
Contributor
|
retest vs please |
Contributor
|
retest this please |
2 similar comments
Contributor
Author
|
retest this please |
Contributor
|
retest this please |
in State DB Table MIRROR_SESSION_TABLE Updated test case to check next_hop_ip in state db. Also test case enahanced to see if route change in propgated correctly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
we do not get expected (key,value) tuple instead of waiting for just key Danny was able to reproduce the issue on local setup. It is more timing issue where if dvs container is running fast we will not see this issue as value get updated quickly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
taking more then 5 seconds. To fix that yse polling interval of 10 seconds.
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
force-pushed
the
mirror_state_db_fix
branch
from
9d7c457 to
06a385a
Compare
Contributor
Author
|
Looks like swss deb package is not correct and @daall has PR to fix that Azure/sonic-build-tools#153 |
daall
previously approved these changes
Aug 19, 2020
Contributor
|
retest vs please |
as they are resolved with sonic-build-tools fix Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
daall
approved these changes
Aug 19, 2020
abdosi
added a commit
that referenced
this pull request
Aug 19, 2020
…d in state DB in ERSPAN Mirror (#1375) * Fix the issue of field "next_hop_ip" not getting updated in State DB Table MIRROR_SESSION_TABLE Updated test case to check next_hop_ip in state db. Also test case enahanced to see if route change in propgated correctly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Fix test failure and address review comments Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Fix for Mirror ERSPAN Failure. Issue is we need to wait till we do not get expected (key,value) tuple instead of waiting for just key Danny was able to reproduce the issue on local setup. It is more timing issue where if dvs container is running fast we will not see this issue as value get updated quickly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * based on syslog on Jenkin route/nexthop update is taking more then 5 seconds. To fix that yse polling interval of 10 seconds. * Increase timeout to 60 seconds Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Added Log Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Revert some of changes done to debug/fix test failure issue as they are resolved with sonic-build-tools fix Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…d in state DB in ERSPAN Mirror (sonic-net#1375) * Fix the issue of field "next_hop_ip" not getting updated in State DB Table MIRROR_SESSION_TABLE Updated test case to check next_hop_ip in state db. Also test case enahanced to see if route change in propgated correctly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Fix test failure and address review comments Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Fix for Mirror ERSPAN Failure. Issue is we need to wait till we do not get expected (key,value) tuple instead of waiting for just key Danny was able to reproduce the issue on local setup. It is more timing issue where if dvs container is running fast we will not see this issue as value get updated quickly. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * based on syslog on Jenkin route/nexthop update is taking more then 5 seconds. To fix that yse polling interval of 10 seconds. * Increase timeout to 60 seconds Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Added Log Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Revert some of changes done to debug/fix test failure issue as they are resolved with sonic-build-tools fix Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Fix the issue of field "next_hop_ip" not getting updated in state DB
Table: MIRROR_SESSION_TABLE when mirror destination ip next hop changes
for ERSPAN Mirror.
Also fixed divs_mirror library to use wait_for_field_match instead wait_for_entry
when comparing expected value for ASIC and State Db Table.
How I Verify:
Updated ERSPAN DVS test case to check next_hop_ip in state db.
Also test case is enhanced to see if route change in propagated correctly
to state and asic db.