[intfsorch] Retrieve Port object before setting NAT zone on router in…#1372
Merged
arlakshm merged 7 commits intosonic-net:masterfrom Aug 11, 2020
Merged
[intfsorch] Retrieve Port object before setting NAT zone on router in…#1372arlakshm merged 7 commits intosonic-net:masterfrom
arlakshm merged 7 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
retest this please |
Contributor
|
restest this please |
arlakshm
reviewed
Aug 5, 2020
|
|
||
| /* Set nat zone id */ | ||
| if ((!nat_zone.empty()) and (port.m_nat_zone_id != nat_zone_id)) | ||
| if (gPortsOrch->getPort(alias, port)) |
Contributor
There was a problem hiding this comment.
this gPortsOrch->getPort(alias, port))check is already done above( line 665). Why do we need to do the check here again ?
Contributor
Author
There was a problem hiding this comment.
@arlakshm RIF objects are created in setIntf() before calling set_nat_zone API and the RIF object handle is set in port.m_rif_id. To get the Port object with rif handle, getPort() is invoked before setting the NAT zone.
Contributor
Author
|
Retest vs please |
Contributor
Author
|
retest this please |
2 similar comments
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Collaborator
|
looks like this is required for 201911 as well, correct? |
Contributor
@prsunny, yes this is required for 201911. I have added the label. |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
Contributor
|
@arlakshm Will wait for PR#1411 for 201911 first and then cherry-pick this. |
Contributor
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
…terfaces. (#1372) Method(setRouterIntfsNatZoneId) is called using local Port object that causes orchagent to crash on config reload with non-zero NAT zone configuration. Orchagent: Retrieve Port object using getPort method before setting NAT zone on Router interfaces. Addressing the issue : #1312 Signed-off-by: Kumaresh Perumal [email protected]
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did Added unit tests for ecnconfig command Updated 'show ecn' command to use run_command wrapper Updated 'config ecn' command to allow configuration of drop probabilities Cleanup trailing spaces in ecnconfig script and add hooks to support unit tests - How to verify it Ran the new ecn_test.py and it passed Signed-off-by: Neetha John <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…terfaces. (sonic-net#1372) Method(setRouterIntfsNatZoneId) is called using local Port object that causes orchagent to crash on config reload with non-zero NAT zone configuration. Orchagent: Retrieve Port object using getPort method before setting NAT zone on Router interfaces. Addressing the issue : sonic-net#1312 Signed-off-by: Kumaresh Perumal [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method(setRouterIntfsNatZoneId) is called using local Port object that causes orchagent to crash on config reload with non-zero NAT zone configuration.
Orchagent:
Retrieve Port object using getPort method before setting NAT zone on Router interfaces.
Addressing the issue : #1312
Signed-off-by: Kumaresh Perumal [email protected]