[chassis]:sonic-swss test changes for Virtual chassis#1345
Merged
daall merged 22 commits intosonic-net:masterfrom Aug 19, 2020
Merged
[chassis]:sonic-swss test changes for Virtual chassis#1345daall merged 22 commits intosonic-net:masterfrom
daall merged 22 commits intosonic-net:masterfrom
Conversation
sonic-net/sonic-buildimage#4709 is a PR for create/delete a virtual chassis. Similar to create_vnet.sh, virtual_chassis.py is used to create the virtual chassis test environment. The changes here are to 1. Add a test_virtual_chassis.py to verify the virtual chassis 2. support virtual chassis topology in conftest.py to run the test_virtual_chassis.py. Notable changes in conftest.py are * Unlike create_vnet, virtual_chassis does not use a sw container. * New DockerVirtualChassisTopology class to setup the connections when the vitual chassis containers restart.
|
|
|
This pull request introduces 1 alert when merging c5ba1eb into 94c622f - view on LGTM.com new alerts:
|
sonic-net/sonic-buildimage#4709 is a PR for create/delete a virtual chassis. Similar to create_vnet.sh, virtual_chassis.py is used to create the virtual chassis test environment. The changes here are to 1. Add a test_virtual_chassis.py to verify the virtual chassis 2. support virtual chassis topology in conftest.py to run the test_virtual_chassis.py. Notable changes in conftest.py are * Unlike create_vnet, virtual_chassis does not use a sw container. * New DockerVirtualChassisTopology class to setup the connections when the vitual chassis containers restart.
swss tests can now start and destroy a virtual chassis from conftest. virtual chassis's neighbors are VirtualServers with ipaddr configured as per the default_config of the neighbor.
remove unused functions
eswaranb
reviewed
Jul 15, 2020
eswaranb
reviewed
Jul 15, 2020
eswaranb
reviewed
Jul 15, 2020
eswaranb
reviewed
Jul 15, 2020
Address review comments remove virtual_chassis.py and README as its not going to be used.
If verify is skipped, the test_virutal_chassis runs too early and fails.
Contributor
|
retest this please |
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
daall
reviewed
Jul 22, 2020
daall
reviewed
Jul 22, 2020
Contributor
daall
left a comment
daall
left a comment
There was a problem hiding this comment.
Overall approach LGTM, a few minor nitpicks in the comments. 🚀
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
lguohan
reviewed
Jul 22, 2020
eswaranb
reviewed
Jul 22, 2020
eswaranb
reviewed
Jul 22, 2020
eswaranb
reviewed
Jul 22, 2020
eswaranb
reviewed
Jul 22, 2020
eswaranb
reviewed
Jul 22, 2020
Use 4 chars for vct's namespace string size use print() remove sysport validations in chassis-db as they will be moved under config-db rename the topology files
|
This pull request introduces 1 alert when merging 5ae8758 into a9479e6 - view on LGTM.com new alerts:
|
address LGTM alert in line 1221
change iteritems to items
small comment to retrigger build
small comment to retrigger build, DBConnector build failure looks unrelated to this PR
lguohan
previously approved these changes
Jul 29, 2020
in conftest, use the utf-8 decode when reading the output in test_virtual_chassis, iter no longer available in python3
saravanansv
force-pushed
the
master-virtualchassistest
branch
from
cd0c3df to
331858f
Compare
Contributor
Author
|
retest vsimage please |
Contributor
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
lguohan
approved these changes
Aug 19, 2020
daall
approved these changes
Aug 19, 2020
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did The 'config' method is getting arguments from the user CLI and build a proper command for the pfcwd script in a wrong way, causing this issue. - How I did it Fix the command structure to align with pfcwd.main script. - How to verify it Run "config pfcwd start --action drop ports all detection-time 400 --restoration-time 400" - Previous command output (if the output of a command-line utility has changed) config pfcwd start --action drop ports all detection-time 400 --restoration-time 400 Failed to run command, invalid options: ports detection-time
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…et#1345) * Add a test_virtual_chassis.py to verify the virtual chassis * Support virtual chassis topology in conftest.py to run the test_virtual_chassis.py. Notable changes in conftest.py are: - Unlike create_vnet, virtual_chassis does not use a sw container. - New DockerVirtualChassisTopology class to setup the connections when the virtual chassis containers restart. * Integrate virtual chassis into conftest.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonic-net/sonic-buildimage#4709 is a perquisite PR to create/delete a virtual chassis.
Similar to create_vnet.sh, virtual_chassis.py is used to create the virtual chassis test environment.
sonic-swss test changes for Virtual chassis
Signed-off-by: Saravanan Sellappa [email protected]
What I did
Notable changes in conftest.py include
virtual chassis containers restart.
Why I did it
In order to verify chassis_db service and related swss changes with new virtual chassis tests under sonic-swss/tests/
How I verified it
Existing sonic-swss/tests still pass. The chassis_db service, connectivity between the chassis instances are verified with test_virtual_chassis.py
Details if related