[FDBSYNCD] Added support for FDBSYNCD for EVPN as described in the PR Azure/SONiC#437 by kishorekunal01 · Pull Request #1276 · sonic-net/sonic-swss

kishorekunal01 · 2020-04-28T21:47:52Z

[FDBSYNCD] Added support for FDBSYNCD for EVPN as described in the PR sonic-net/SONiC#437

This Change set is to support EVPN MAC/IMET routes from Kernel to DB and DB to Kernel.

What I did

New demon is added to sync MAC from Kernel to DB and vise versa.
Add remote IMET route learned via EVPN to EVPN_REMOTE_VNI_TABLE in APP_DB.
Add remote MAC route learned via EVPN to VXLAN_FDB_TABLE.
Add State DB FDB_TABLE for local learned MAC to Kernel

Why I did it
Part of overall EVPN-VXLAN Implementation

How I verified it
Not yet compiled or verified

Details if related
HLD Location : https://github.com/Azure/SONiC/pull/437/commits

Signed-off-by: Kishore Kunal [email protected]

lguohan · 2020-04-29T21:17:27Z

need vs test to cover this feature.

fdbsyncd/Makefile.am

fdbsyncd/fdbsync.cpp

msftclas · 2020-05-14T17:13:42Z

All CLA requirements met.

gord1306 · 2020-05-21T08:13:00Z

fdbsyncd/fdbsync.cpp

+
+FdbSync::FdbSync(RedisPipeline *pipelineAppDB, DBConnector *stateDb) :
+    m_fdbTable(pipelineAppDB, APP_VXLAN_FDB_TABLE_NAME),
+    m_imetTable(pipelineAppDB, APP_EVPN_REMOTE_VNI_TABLE_NAME),


According to sonic-swss-common PR339, should this constant be renamed to APP_VXLAN_REMOTE_VNI_TABLE_NAME

Thanks for review. Updated the same

gord1306 · 2020-05-21T08:13:23Z

fdbsyncd/fdbsync.cpp

+    if (m_AppRestartAssist)
+    {
+        m_AppRestartAssist->registerAppTable(APP_VXLAN_FDB_TABLE_NAME, &m_fdbTable);
+        m_AppRestartAssist->registerAppTable(APP_EVPN_REMOTE_VNI_TABLE_NAME, &m_imetTable);


According to sonic-swss-common PR339, should this constant be renamed to APP_VXLAN_REMOTE_VNI_TABLE_NAME

Thanks for review. Updated the same

gord1306 · 2020-05-21T08:15:40Z

fdbsyncd/fdbsync.cpp

+	// If warmstart is in progress, we take all netlink changes into the cache map
+    if (m_AppRestartAssist->isWarmStartInProgress())
+    {
+        m_AppRestartAssist->insertToMap(APP_EVPN_REMOTE_VNI_TABLE_NAME, key, fvVector, false);


According to sonic-swss-common PR339, should this constant be renamed to APP_VXLAN_REMOTE_VNI_TABLE_NAME

Thanks for review. Updated the same

gord1306 · 2020-05-21T08:15:46Z

fdbsyncd/fdbsync.cpp

+    // If warmstart is in progress, we take all netlink changes into the cache map
+    if (m_AppRestartAssist->isWarmStartInProgress())
+    {
+        m_AppRestartAssist->insertToMap(APP_EVPN_REMOTE_VNI_TABLE_NAME, key, fvVector, true);


According to sonic-swss-common PR339, should this constant be renamed to APP_VXLAN_REMOTE_VNI_TABLE_NAME

Thanks for review. Updated the same

gord1306 · 2020-07-09T09:47:25Z

fdbsyncd/fdbsync.cpp

+		fdbmac.erase(key);
+    }
+
+    if (fdb_type == FDB_TYPE_DYNAMIC)


There is a question about the bridge fdb command, whether the remote MAC need to have extern_learn field

Thanks for review, Yes extern_learn flag need to be set but currently exec command doesn't has extern_learn support, Hence it is not set.

This API is delete from common library, so delete the call as well

Address the review comments

Updated based on review comments

Updated based on the comment

comment from Qi.

fdbsyncd/fdbsync.h

fdbsyncd/fdbsyncd.cpp

fdbsyncd/fdbsync.h

fdbsyncd/fdbsync.cpp

sonic-net/SONiC#437

kishorekunal01

All review comment address. WIll raise 2 more PR for the sonic-buildimage to start fdbsyncd process, and adding a table for warm reboot store in swss-common

kishorekunal01 · 2020-11-12T21:33:08Z

fdbsyncd/fdbsync.cpp

+
+    if (info->op_type == FDB_OPER_ADD)
+    {
+        macAddSrcDB(info);


We can't move this to caller since we use the DB data to send del to the kernel and we want to keep add/del from DB at one place.

kishorekunal01 · 2020-11-12T23:56:15Z

fdbsyncd/fdbsync.cpp

+    }
+    else
+    {
+        /* If this is for vnet bridge vxlan interface, then return */


@prsunny If the interface is Vxlan and is Vnet interface then return from here. Am I missing something

kishorekunal01 · 2020-11-13T00:20:00Z

fdbsyncd/fdbsync.cpp

+        return;
+    }
+    SWSS_LOG_INFO("Op:%d VxLAN dev %s index:%d vni:%d", nlmsg_type, ifname? ifname: nil, ifindex, vni);
+    if (nlmsg_type == RTM_NEWLINK)


We are only creating interface for vxlan interface so that we can extract VNI information for MAC installation, When interface is delete, each MAC del will be received in the kernel. Hence we don't need to handle interface delete here.

prsunny · 2020-12-04T16:34:38Z

retest this please

…NiC#437 (sonic-net#1276) * [FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD. This Change set is to support EVPN MAC/IMET routes from Kernel to DB and DB to Kernel: New demon is added to sync MAC from Kernel to DB and vise versa. Add remote IMET route learned via EVPN to EVPN_REMOTE_VNI_TABLE in APP_DB. Add remote MAC route learned via EVPN to VXLAN_FDB_TABLE. Add State DB FDB_TABLE for local learned MAC to Kernel Signed-off-by: Kishore Kunal [email protected] Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>

…onic-net#1276) **- What I did** Fix that it cannot add loopback interface by CLI, like the following: ``` root@as7816-64x:~# config loopback add Loopback1 Usage: config [OPTIONS] COMMAND [ARGS]... Try "config --help" for help. Error: No such command "L". ``` **- How I did it** Remove `@config.group()` before the function `is_loopback_name_valid(loopback_name)`, which will be called by add/del command Signed-off-by: MuLin <[email protected]>

…NiC#437 (sonic-net#1276) * [FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD. This Change set is to support EVPN MAC/IMET routes from Kernel to DB and DB to Kernel: New demon is added to sync MAC from Kernel to DB and vise versa. Add remote IMET route learned via EVPN to EVPN_REMOTE_VNI_TABLE in APP_DB. Add remote MAC route learned via EVPN to VXLAN_FDB_TABLE. Add State DB FDB_TABLE for local learned MAC to Kernel Signed-off-by: Kishore Kunal [email protected]

gord1306 reviewed May 12, 2020

View reviewed changes

fdbsyncd/Makefile.am Outdated Show resolved Hide resolved

gord1306 reviewed May 12, 2020

View reviewed changes

fdbsyncd/fdbsync.cpp Outdated Show resolved Hide resolved

gord1306 reviewed May 21, 2020

View reviewed changes

[FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD.

1730a6c

gord1306 reviewed Jul 9, 2020

View reviewed changes

kishorekunal01 and others added 16 commits September 21, 2020 11:22

Update fpmsyncd.cpp

8de4b36

Update fpmlink.cpp

cf4ed79

Update fpmlink.cpp

8bc8d5d

Update fpmlink.cpp

2189e1a

Update routesync.cpp

46e7c96

Update routesync.cpp

d94dcdc

Update routesync.cpp

a51d079

This API is delete from common library, so delete the call as well

Update fpmlink.cpp

23b06ab

Update routesync.cpp

9ac6f05

Address the review comments

Update routesync.h

8d383bb

Updated based on review comments

Update routesync.cpp

3c29e28

Updated based on the comment

Fix all the review comment from Prince

fb50f03

Updated by directly calling the raw message process as per review

9992702

comment from Qi.

Fix space

95a50d3

Updated based on new review comments

1cacae7

Merge branch 'master' of https://github.com/Azure/sonic-swss

b9cdeaa

prsunny requested changes Oct 30, 2020

View reviewed changes

kishorekunal01 added 3 commits October 30, 2020 11:51

VS test run might be failing due to this.

67187a4

Removing un-used code

b7c6a32

[FDBSYNCD] Added support for FDBSYNCD as described in the PR

b90c15e

sonic-net/SONiC#437

kishorekunal01 added 3 commits November 13, 2020 17:26

Update Makefile.am

44681f7

Update fdbsync.cpp

11f717c

Update fdbsync.cpp

877ec26

kishorekunal01 force-pushed the evpn_fdbsyncd branch from 78717d2 to 877ec26 Compare November 14, 2020 01:29

nkelapur mentioned this pull request Nov 17, 2020

[Evpn Warmreboot] Added Dependancy check logic in VrfMgr #1466

Merged

kishorekunal01 added 3 commits November 18, 2020 20:56

Merge remote-tracking branch 'upstream/master'

3cd4c75

Merge branch 'master' into evpn_fdbsyncd

0001efe

All the review comment are address in the changes

fa2be23

kishorekunal01 commented Nov 19, 2020

View reviewed changes

kishorekunal01 mentioned this pull request Nov 19, 2020

Table to store fdb restore table for fdbsyncd sonic-net/sonic-swss-common#417

Closed

Remove variable not used

1f907b7

Praveen-Brcm mentioned this pull request Dec 9, 2020

Mclag enhacements support code changes. #1331

Merged

prsunny approved these changes Dec 11, 2020

View reviewed changes

prsunny merged commit 14d8c5f into sonic-net:master Dec 11, 2020

stephenxs mentioned this pull request Dec 16, 2020

[submodule] Advance submodule head for sonic-swss and sonic-utilities stephenxs/sonic-buildimage#47

Closed

3 tasks

Conversation

kishorekunal01 commented Apr 28, 2020

Uh oh!

lguohan commented Apr 29, 2020

Uh oh!

Uh oh!

Uh oh!

msftclas commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kishorekunal01 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prsunny commented Dec 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msftclas commented May 14, 2020 •

edited

Loading