[dvs] Refactor NAT tests to use redis polling fixtures#1220
Merged
daall merged 4 commits intosonic-net:masterfrom Mar 23, 2020
Merged
[dvs] Refactor NAT tests to use redis polling fixtures#1220daall merged 4 commits intosonic-net:masterfrom
daall merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <[email protected]>
Contributor
Author
|
retest this please |
Contributor
Author
|
depends on sonic-net/sonic-buildimage#4259 |
Contributor
|
retest this please |
lguohan
previously approved these changes
Mar 16, 2020
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
lguohan
approved these changes
Mar 23, 2020
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Danny Allen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
What I did
I refactored the NAT tests to use the redis polling fixtures added by #1213.
Why I did it
The NAT tests are failing intermittently due to timing issues, which is blocking PR builds.
How I verified it
Details if related
Pre-refactor test results: 8/10 test runs passed, 52s average
Post-refactor test results: 10/10 test runs passed, 52s average