Closed
Conversation
* VLAN dependency handling for Dynamic Port Breakout:
Set port::VLAN_DEP bit when port is added to first VLAN
Clear port::VLAN_DEP bit when port is removed from all VLANs
Collaborator
|
Is this PR relevant as #1147 is closed? |
Contributor
Author
|
This is still relevant, but as discussed with Microsoft team, I will update the way we check dependency |
Contributor
Author
|
Obsolete. As changes have been captured in other PR. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Fix the issue where Rx counts were overwritten by the Tx counts Signed-off-by: Neetha John <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is dependent on #1112 and #1147
Set port::VLAN_DEP bit when port is added to first VLAN
Clear port::VLAN_DEP bit when port is removed from all VLANs
What I did
Track VLAN dependency on port and set/clear the dependency bit accordingly
Why I did it
So, that we can breakout the port when its part of VLAN(s)
How I verified it
Wrote VS test cases, and ran existing VS test cases
Details if related