[MultiDB]: using new APIs in orch agents and mock_tests by dzhangalibaba · Pull Request #1138 · sonic-net/sonic-swss

dzhangalibaba · 2019-11-21T01:21:52Z

replacing old APIs with new APIs in orch agents
fix mock_tests cases
- adding database_config.json
- adding mock DBConnector(X, X)
- using new APIs in mock_tests

Signed-off-by: Dong Zhang [email protected]

dzhangalibaba · 2019-11-21T19:02:44Z

@qiluo-msft
BTW for this PR, we need the latest vs docker image to pass vs tests. sonic-net/sonic-buildimage#3757 . IS the vs docker images updated automatically or we need manually update vs docker ?

qiluo-msft

Looks good to me. Make sure vs test pass.

qiluo-msft · 2019-11-21T20:51:15Z

Retest this please

dzhangalibaba · 2019-11-21T22:26:22Z

Thanks for reviewing.
FYI, I ran vs tests passed on local. Looks swss build on Jenkis failed for a while recently. Any reason ?
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/

Looks good to me. Make sure vs test pass.

dzhangalibaba · 2019-11-22T22:20:00Z

retest this please

prsunny · 2019-11-23T00:58:15Z

retest this please

dzhangalibaba · 2019-11-25T20:02:02Z

retest this please

dzhangalibaba · 2019-11-25T22:45:55Z

retest this please

dzhangalibaba · 2019-11-26T01:26:04Z

one question， the vs tests looks having some issues itself. I run "retest this please" many times, every time , it report different failure cases. If we check two vs tests together, then all test cases are passed. Looks to pass vs tests needs luck ???

dzhangalibaba · 2019-11-26T09:10:08Z

retest this please

dzhangalibaba · 2019-11-26T13:18:02Z

retest this please

dzhangalibaba · 2019-11-26T19:01:53Z

retest this please

dzhangalibaba · 2019-11-26T21:52:09Z

after several tries, vs tests passed. @qiluo-msft

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596 * addressed LGTM alert * UT Fix unique IP configuration * modified ip address validate function for mclag config verication * Add soft-reboot reboot type (sonic-net#1453) What I did Add a new reboot named as soft-reboot which can be performed by "kexec -e" How I did it Replace the platform reboot with "kexec -e" for the cold reboot case. How to verify it Verified the reboot on DUT and check the reboot-cause * [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) Check if any warm restart flag is set when issuing a warm-reboot. This check avoids starting a warm reboot while another warm restart is in progress. In the scenario where a warm reboot is issued with another warm restart in progress, the warm restart flag may be reset and part of the components have a risk of doing cold reboot. * Added mclag config commands * removed unwanted imports * added mclag tests * fixed build issue * corrected mclag test * corrected mclag test * corrected mclag test case * updated testcase for mclag * updated mclag config * updated mclag test cases * updated mclag test case * updated mclag test cases * fixed alert * updated mclag test cases * updated mclag test cases * updated mclag config * modified mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test case * updated mclag config to use swsscommon instead of swssdk * updated mclag config to use swsscommon * updated mclag config script file * fixed mclag test cases to verify config db * updated mclag test case with config db verify function * fixed build issue * updated test case * updated mclag test case * addressed review comments Co-authored-by: Tapash Das <[email protected]> Co-authored-by: Tapash Das <[email protected]> Co-authored-by: Sujin Kang <[email protected]> Co-authored-by: Shi Su <[email protected]>

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in #1138

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138 Signed-off-by: Baorong Liu <[email protected]>

[MultiDB]: using new APIs in orch agents and mocktest

fa5c6a4

qiluo-msft approved these changes Nov 21, 2019

View reviewed changes

qiluo-msft requested a review from lguohan November 21, 2019 20:51

qiluo-msft mentioned this pull request Nov 21, 2019

[MultiDB]: apply new APIs in swss-common sonic-net/sonic-swss-common#316

Merged

qiluo-msft merged commit fc085ee into sonic-net:master Nov 26, 2019

dzhangalibaba deleted the multidb_swss branch December 17, 2019 19:57

lguohan added the request_for_201911_branch label Dec 27, 2019

abdosi pushed a commit that referenced this pull request Jan 3, 2020

[MultiDB]: using new APIs in orch agents and mocktest (#1138)

2412ef9

abdosi added the Included in 201911 Branch label Jan 7, 2020

Praveen-Brcm mentioned this pull request Jul 9, 2021

Mclag enhacements support code changes. #1331

Merged

Pan-XT mentioned this pull request Sep 19, 2024

[MultiDB]:sonic-swss replace old API with new APIs #3292

Merged

lguohan pushed a commit that referenced this pull request Nov 1, 2024

[MultiDB]:sonic-swss replace old API with new APIs (#3292)

368e1d6

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in #1138

stepanblyschak pushed a commit to stepanblyschak/sonic-swss that referenced this pull request Nov 13, 2024

[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)

1fca0d0

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138

shiraez pushed a commit to Marvell-switching/sonic-swss that referenced this pull request Feb 17, 2025

[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)

b488f76

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138

liuh-80 pushed a commit to liuh-80/sonic-swss that referenced this pull request Apr 7, 2025

[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)

0d74611

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025

[MultiDB]: using new APIs in orch agents and mocktest (sonic-net#1138)

b8318b8

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025

[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)

97eccaa

Replace DBConnector old APIs with new APIs to enable Multi DB I implemented similar changes in sonic-net#1138

Conversation

dzhangalibaba commented Nov 21, 2019

Uh oh!

dzhangalibaba commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

qiluo-msft commented Nov 21, 2019

Uh oh!

dzhangalibaba commented Nov 21, 2019

Uh oh!

dzhangalibaba commented Nov 22, 2019

Uh oh!

prsunny commented Nov 23, 2019

Uh oh!

dzhangalibaba commented Nov 25, 2019

Uh oh!

dzhangalibaba commented Nov 25, 2019

Uh oh!

dzhangalibaba commented Nov 26, 2019

Uh oh!

dzhangalibaba commented Nov 26, 2019

Uh oh!

dzhangalibaba commented Nov 26, 2019

Uh oh!

dzhangalibaba commented Nov 26, 2019

Uh oh!

dzhangalibaba commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dzhangalibaba commented Nov 21, 2019 •

edited

Loading