[vs tests]: Add mirror session warm reboot test#1130
Closed
daall wants to merge 2 commits intosonic-net:masterfrom
Closed
[vs tests]: Add mirror session warm reboot test#1130daall wants to merge 2 commits intosonic-net:masterfrom
daall wants to merge 2 commits intosonic-net:masterfrom
Conversation
This test validates the post baking stage that recovers the monitor port picked before the warm reboot. Signed-off-by: Shu0T1an ChenG <[email protected]>
Contributor
Author
|
retest this please |
2 similar comments
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
Reopening this PR because the feature branch was deleted inadvertently. 🤦♂ |
yxieca
reviewed
Jan 14, 2020
|
|
||
| # Setup the virtual switch | ||
| dvs.setup_db() | ||
| dvs.runcmd("config warm_restart enable swss") |
Contributor
There was a problem hiding this comment.
I suggest moving warm restart setting close to swss restart.
yxieca
reviewed
Jan 14, 2020
| # Perform the warm reboot | ||
| dvs.stop_swss() | ||
| dvs.start_swss() | ||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
is sleep 5 seconds enough? You could polling "show warm_restart state" and wait until orchagent is reconciled. That would take lot longer than 5 seconds though.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ic-net#1130) * [update] removed actual baud from consutil show result table * [refine] ensure only 1 db querying per command * [refine] refactor code for better reusing in future * [new] add a new return value ERR_CFG for indicating configuration issue Signed-off-by: [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added a test case to validate that the monitor port is preserved during warm reboot.
Why I did it
To validate #1054
How I verified it
Details if related
Continuation of #1097