Natsyncd changes in sonic-swss submodule to support NAT feature. by AkhileshSamineni · Pull Request #1126 · sonic-net/sonic-swss

AkhileshSamineni · 2019-11-11T07:36:25Z

Added natsyncd and warmboot related changes.

Link to NAT HLD : https://github.com/Azure/SONiC/blob/master/doc/nat/nat_design_spec.md

Depends on:
sonic-swss : #1059 and #1125
sonic-swss-common : sonic-net/sonic-swss-common#304
sonic-linux-kernel : sonic-net/sonic-linux-kernel#100
sonic-sairedis : sonic-net/sonic-sairedis#519

… as part of PRs sonic-net#1125 and sonic-net#1126

arlakshm · 2019-11-13T23:35:01Z

neighsyncd/neighsync.cpp

-    m_AppRestartAssist(pipelineAppDB, "neighsyncd", "swss", &m_neighTable, DEFAULT_NEIGHSYNC_WARMSTART_TIMER)
+    m_stateNeighRestoreTable(stateDb, STATE_NEIGH_RESTORE_TABLE_NAME)
 {
+    m_AppRestartAssist = new AppRestartAssist(pipelineAppDB, "neighsyncd", "swss", DEFAULT_NEIGHSYNC_WARMSTART_TIMER);


Can please elaborate why we need the changes in neighsyncd and warmrestartAssist ?

@arlakshm The AppRestartAssist class was handling the reconciliation logic only for a single app-db table. This class is enhanced to handle reconciliation logic for multiple app-db tables, if the user of this class is the producer for multiple app-db ables as in the case of NAT. Earlier neighsyncd is the producer for a single app-db table and passing the app-db table to AppRestartAssist. Since this class is enhanced now, neighsyncd code is modified to call the new APIs.

arlakshm · 2019-11-15T01:30:48Z

natsyncd/natsync.cpp

+                                /* If a matching Static NAPT entry exists in the APP_DB,
+                                 * it has higher priority than the dynamic napt entry. */
+                                SWSS_LOG_INFO("SNAPT %s: static entry exists, not processing the NAPT notification", opStr.c_str());
+                                if (m_AppRestartAssist->isWarmStartInProgress())


This condition may not be hit ? on the top we are checking if (! m_AppRestartAssist->isWarmStartInProgress())

Yes, this is dead code, will remove it.

arlakshm · 2019-11-15T01:30:56Z

natsyncd/natsync.cpp

+                        }
+                        else
+                        {
+                            if (m_AppRestartAssist->isWarmStartInProgress())


same as above

Yes, this is dead code, will remove it.

arlakshm · 2019-11-15T01:32:44Z

natsyncd/natsync.cpp

+ *   - If SNAPT and DNAPT conditions are met or if there is no static
+ *       or dynamic Twice NAT entry, then it is a Twice NAPT entry.
+ */
+int NatSync::addNatEntry(struct nfnl_ct *ct, struct naptEntry &entry, bool addFlag)


There are lot of DB gets and checks being done in this function. Will there be a performance impact in-terms of Netlink message loss, when the scale is high ?

Per NAT entry, atmost 2 db gets are done and not seen netlink message loss with 600 pps traffic.
DB gets are done to avoid storing another copy of nat tables (apart from appl_db) within natsyncd.

marian-pritsak · 2019-11-12T15:39:01Z

natsyncd/natsyncd.cpp

+            nfnl.registerGroup(NFNLGRP_CONNTRACK_UPDATE);
+            nfnl.registerGroup(NFNLGRP_CONNTRACK_DESTROY);
+
+            cout << "Listens to conntrack messages..." << endl;


marian-pritsak · 2019-11-12T15:52:41Z

natsyncd/natsync.cpp

+            {
+                /* If a matching Static Twice NAT entry exists in the APP_DB,
+                 * it has higher priority than the dynamic twice nat entry. */
+                if ((fvField(iter) == "entry_type") && (fvValue(iter) == "static"))


How was it even trapped if a static entry exists?

For static snat entry, the packet can come up in case of h/w L3 destination lookup failure. To handle such cases, we need the SNAT rule for static entry in the iptables.

… as part of PRs sonic-net#1125 and sonic-net#1126

- Added natsyncd and warmboot related changes. Link to NAT HLD : https://github.com/Azure/SONiC/blob/master/doc/nat/nat_design_spec.md Depends on: sonic-swss : sonic-swss-common : sonic-net/sonic-swss-common#304 sonic-linux-kernel : sonic-net/sonic-linux-kernel#100 sonic-sairedis : sonic-net/sonic-sairedis#519

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

AkhileshSamineni · 2019-12-10T15:43:40Z

Retest this please.

AkhileshSamineni · 2020-01-10T09:24:45Z

retest this please.

AkhileshSamineni · 2020-01-13T06:01:34Z

Retest this please.

AkhileshSamineni · 2020-01-13T12:52:42Z

Retest this please.

AkhileshSamineni · 2020-01-14T13:45:48Z

Retest this please.

Add the missing import of `netaddr` for `show ip interfaces`. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

…ic-net#1126)

AkhileshSamineni added a commit to AkhileshSamineni/sonic-swss that referenced this pull request Nov 11, 2019

Removed the Orchagent and Natsyncd related files as those are covered…

df5863b

… as part of PRs sonic-net#1125 and sonic-net#1126

This was referenced Nov 11, 2019

Natmgrd changes in sonic-swss sub module to support NAT feature. #1059

Merged

Orchagent changes in sonic-swss submodule to support NAT feature. #1125

Merged

arlakshm reviewed Nov 13, 2019

View reviewed changes

arlakshm reviewed Nov 15, 2019

View reviewed changes

marian-pritsak requested changes Nov 19, 2019

View reviewed changes

kirankella mentioned this pull request Nov 21, 2019

Changes in sonic-sairedis repo to support the NAT feature. sonic-net/sonic-sairedis#519

Merged

AkhileshSamineni requested a review from marian-pritsak November 22, 2019 10:06

marian-pritsak approved these changes Nov 22, 2019

View reviewed changes

AkhileshSamineni added a commit to AkhileshSamineni/sonic-swss that referenced this pull request Dec 10, 2019

Removed the Orchagent and Natsyncd related files as those are covered…

fd733b8

… as part of PRs sonic-net#1125 and sonic-net#1126

AkhileshSamineni added 3 commits December 10, 2019 01:56

Addressed Review comments

e4b7724

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Addressed review comments

3ca530c

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

AkhileshSamineni force-pushed the natsyncd_changes_in_sonic branch from 2ef39c6 to 3ca530c Compare December 10, 2019 09:57

arlakshm self-requested a review December 20, 2019 19:03

arlakshm approved these changes Dec 20, 2019

View reviewed changes

rlhui merged commit bbd77fc into sonic-net:master Jan 19, 2020

lguohan added a commit that referenced this pull request Jan 30, 2020

Natsyncd changes in sonic-swss submodule to support NAT feature. (#1126)

dc7e5f0

rlhui added the request_for_201911_branch label Jan 31, 2020

abdosi added the Included in 201911 Branch label Feb 4, 2020

abdosi pushed a commit that referenced this pull request Feb 4, 2020

Natsyncd changes in sonic-swss submodule to support NAT feature. (#1126)

6fb448b

zhenggen-xu mentioned this pull request Nov 18, 2020

[fast-reboot] Add a check for warmstart before cleaning up neigh table #1498

Merged

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022

[show] Add missing import to fix show ip interfaces (sonic-net#1126)

2f79ac1

Add the missing import of `netaddr` for `show ip interfaces`. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025

Natsyncd changes in sonic-swss submodule to support NAT feature. (son…

ccbe0bd

…ic-net#1126)

Conversation

AkhileshSamineni commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AkhileshSamineni commented Dec 10, 2019

Uh oh!

AkhileshSamineni commented Jan 10, 2020

Uh oh!

AkhileshSamineni commented Jan 13, 2020

Uh oh!

AkhileshSamineni commented Jan 13, 2020

Uh oh!

AkhileshSamineni commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AkhileshSamineni commented Nov 11, 2019 •

edited

Loading