[vnet]: Fix double route installation for BITMAP VNET interface#1114
Merged
prsunny merged 3 commits intosonic-net:masterfrom Apr 3, 2020
Merged
[vnet]: Fix double route installation for BITMAP VNET interface#1114prsunny merged 3 commits intosonic-net:masterfrom
prsunny merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
Collaborator
|
Right now the route orch installs routes using sai_route_api, not sai_bitmap_router_api. For the VNET interfaces, it must remain with sai_bitmap_router_api. |
Collaborator
Collaborator
|
retest this please |
…map_vnet_fix Conflicts: orchagent/vnetorch.cpp
Collaborator
|
@volodymyrsamotiy , can you check it VS test failure? Its |
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
marian-pritsak
approved these changes
Apr 3, 2020
prsunny
approved these changes
Apr 3, 2020
abdosi
pushed a commit
that referenced
this pull request
Apr 7, 2020
* [vnet]: Fix double route installation for BITMAP VNET interface
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Create fabric ports for switch_type fabric. This is needed to create vs test for fabric on supervisor.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…c-net#1114) * [vnet]: Fix double route installation for BITMAP VNET interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com
What I did
Fixed double route installation for BITMAP VNET interface
Why I did it
Removed logic to add/remove subnet route for VNET interface in BITMAP orchagent since now routes should be added/removed by
routeorch.How I verified it
Ran VNET ansible test
Details if related
N/A