Skip to content

[fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 3 commits into from
Oct 31, 2019
Merged

[fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case #1111

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9939c4
Check if pfc is at on state over the polling period for queue occupan…
wendani Oct 29, 2019
0df1292
Use the same condition for queue occupany zero and non-zero cases
wendani Oct 30, 2019
b516998
Remove single line comments that no longer valid
yxieca Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions orchagent/pfc_detect_broadcom.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,10 @@ for i = n, 1, -1 do
pfc_on2off_last = tonumber(pfc_on2off_last)

-- Check actual condition of queue being in PFC storm
if (occupancy_bytes > 0 and packets - packets_last == 0 and pfc_rx_packets - pfc_rx_packets_last > 0) or
if (pfc_rx_packets - pfc_rx_packets_last > 0 and pfc_on2off - pfc_on2off_last == 0 and queue_pause_status_last == 'true' and queue_pause_status == 'true') or
-- DEBUG CODE START. Uncomment to enable
(debug_storm == "enabled") or
(debug_storm == "enabled") then
-- DEBUG CODE END.
(occupancy_bytes == 0 and pfc_rx_packets - pfc_rx_packets_last > 0 and pfc_on2off - pfc_on2off_last == 0 and queue_pause_status_last == 'true' and queue_pause_status == 'true') then
if time_left <= poll_time then
redis.call('PUBLISH', 'PFC_WD_ACTION', '["' .. KEYS[i] .. '","storm"]')
is_deadlock = true
Expand Down