Skip to content

Apply buffer profiles: not wait till kernel net_devices are created for all physical ports#1109

Merged
lguohan merged 2 commits intosonic-net:masterfrom
wendani:buf_apply
Nov 4, 2019
Merged

Apply buffer profiles: not wait till kernel net_devices are created for all physical ports#1109
lguohan merged 2 commits intosonic-net:masterfrom
wendani:buf_apply

Conversation

@wendani
Copy link
Copy Markdown
Contributor

@wendani wendani commented Oct 29, 2019

Apply buffer profiles when hardware physical ports are created

Introduce a mini state machine to track the portConfigState transition on receiving event from APPL_DB PORT_TABLE

Signed-off-by: Wenda Ni wenni@microsoft.com

What I did

Why I did it

How I verified it
On brcm dut

Cold reboot

Oct 30 03:46:13.403689 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: key PortConfigDone received, transit to state PORT_CONFIG_RECEIVED*

Oct 30 03:46:14.346703 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: transit to state PORT_CONFIG_DONE

Oct 30 03:46:14.566002 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: admin up port Ethernet112
Oct 30 03:46:14.566813 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: state PORT_CONFIG_DONE

Oct 30 03:46:14.570333 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: admin up port Ethernet116
Oct 30 03:46:14.570545 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: state PORT_CONFIG_DONE

Details if related

apply buffer profiles, but when hardware physical ports are created

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested review from lguohan and qiluo-msft October 29, 2019 02:53
@wendani wendani changed the title Not wait till kernel net_devices are created for all physical ports to apply buffer profiles Apply buffer profiles: not wait till kernel net_devices are created for all physical ports Oct 29, 2019
@wendani
Copy link
Copy Markdown
Contributor Author

wendani commented Oct 29, 2019

retest this please

@wendani
Copy link
Copy Markdown
Contributor Author

wendani commented Oct 29, 2019

retest this please

@wendani
Copy link
Copy Markdown
Contributor Author

wendani commented Oct 29, 2019

@stepanblyschak to review

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 30, 2019

how much time saving is here?

@wendani
Copy link
Copy Markdown
Contributor Author

wendani commented Nov 1, 2019

No significant time saving observed in cold reboot. #1109 (comment)

@lguohan lguohan merged commit bb4e19c into sonic-net:master Nov 4, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
sonic-net#1109)

Apply buffer profiles when hardware physical ports are created

Introduce a mini state machine to track the portConfigState transition on receiving event from APPL_DB PORT_TABLE

Signed-off-by: Wenda Ni <wenni@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants