Error Handling Framework: Orchestration changes to report SAI API failures#1100
Error Handling Framework: Orchestration changes to report SAI API failures#1100sivamukka wants to merge 3 commits intosonic-net:masterfrom
Conversation
sivamukka
force-pushed
the
error_handling
branch
from
8514000 to
1636a27
Compare
sivamukka
force-pushed
the
error_handling
branch
from
1636a27 to
de4feca
Compare
sivamukka
changed the title
daall
left a comment
daall
left a comment
There was a problem hiding this comment.
Review is in the comments. Let me know if you have any questions!
| /* | ||
| * Copyright 2019 Broadcom Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Did you mean to include this?
There was a problem hiding this comment.
Yes. It's a new file added as part of error handling framework.
There was a problem hiding this comment.
Sorry for the confusion! I meant the license header, not the file itself. 😝
We don't include a license header in any of the source files in SWSS - that information is available at the top of the repo. You can delete this comment.
There was a problem hiding this comment.
This file header is present for all contributions from Broadcom. Please let me know if this is a concern.
orchagent/errororch.cpp
Outdated
| std::shared_ptr<Table> table; | ||
|
|
||
| /* | ||
| * The following steps are performed: |
There was a problem hiding this comment.
Same as above, the comments are helpful but putting the different steps into explicit methods would help with readability.
There was a problem hiding this comment.
Done. Added comments at individual sections.
| return true; | ||
| } | ||
|
|
||
| bool NeighOrch::mapToErrorDbFormat(sai_object_type_t& object_type, std::vector<FieldValueTuple> &asicValues, |
There was a problem hiding this comment.
Just a suggestion but it might be helpful to break this up based on the type of interface for readability.
There was a problem hiding this comment.
I would like to leave it as is, as we have only two types of interfaces
sivamukka
force-pushed
the
error_handling
branch
from
c448fd8 to
ec1b2a8
Compare
- Receives notifications from syncd - Process the notifications from syncd and logs the errors into error database - Notify the status to registered applications
sivamukka
force-pushed
the
error_handling
branch
from
c546bf3 to
5c1fe20
Compare
…t-boot (sonic-net#1100) Fast-reboot is utilizing warm-reboot infrastructure to improve its performance, but it should ignore warm-boot logic when syncd starts in fast-boot. As well it shouldn't use temporary view between init and apply.
…ses (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) Due to sonic-net#1100 To unblock submodule move Revert 2 PRs: cf7c7f6 2025-12-01 | Fix issue where namespace would not be read (sonic-net#1111) [Connor Roos] 4fea06e 2025-10-07 | [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) [Connor Roos]
2 participants
Error handling framework is responsible for notifying ASIC/SAI programming failures to the applications.
Changes in OrchAgent includes:
Dependent PRs:
sonic-net/sonic-swss-common#309
Related PRs:
sonic-net/sonic-utilities#666
sonic-net/sonic-sairedis#523
Signed-off-by: Siva Mukka ([email protected])