[teamsyncd]: Do not update lag mtu from teamsyncd (netlink)#1053
Merged
prsunny merged 1 commit intosonic-net:masterfrom Sep 18, 2019
Merged
[teamsyncd]: Do not update lag mtu from teamsyncd (netlink)#1053prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
@hzheng5, please review |
yxieca
approved these changes
Sep 11, 2019
lguohan
approved these changes
Sep 11, 2019
stcheng
approved these changes
Sep 11, 2019
hzheng5
approved these changes
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Revert changes done as part of #922
Why I did it
In some use-cases it is required that kernel MTU is different (may be default 1500) from the config_db value (say 9000). In this case, if
teamsyncdupdates the MTU value via Netlink, orchagent/asic mtu value would be different from the user configured value. We wantteammgrwhich listens on config db to update the mtu value to APP_DB.Original change was done due to a timing issue where mtu value was found to be missing in APP_DB. This resulted in orchagent creating router interface with 1492 mtu value - Logs are in details
How I verified it
Load the changes and
reboot,config reloadand check ifmtuis correct inAPP_DBas expected.Details if related