Skip to content

[portsyncd]: Add default catch block in portsyncd #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stcheng merged 4 commits into from
Aug 22, 2019
Merged

[portsyncd]: Add default catch block in portsyncd #1033

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62a06f3
Add default catch block in portsyncd
SuvarnaMeenakshi Aug 19, 2019
5964b5c
Updated error message with the right spelling
SuvarnaMeenakshi Aug 19, 2019
6e26797
[portsyncd]: Update try block to throw exception of type runtime_error
SuvarnaMeenakshi Aug 21, 2019
a1c4509
[portsyncd]: Remove additional paranthesis in throw statement
SuvarnaMeenakshi Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions portsyncd/portsyncd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,15 @@ int main(int argc, char **argv)
}
catch (const std::exception& e)
{
cerr << "Exception \"" << e.what() << "\" had been thrown in deamon" << endl;
cerr << "Exception \"" << e.what() << "\" was thrown in daemon" << endl;
return EXIT_FAILURE;
}
catch (...)
{
cerr << "Exception was thrown in daemon" << endl;
return EXIT_FAILURE;
}


return 1;
}
Expand Down Expand Up @@ -224,7 +230,7 @@ void handlePortConfigFile(ProducerStateTable &p, string file, bool warm)
if (!infile.is_open())
{
usage();
throw "Port configuration file not found!";
throw runtime_error("Port configuration file not found!");
}

list<string> header = {"name", "lanes", "alias", "speed", "autoneg", "fec"};
Expand Down