Update ECMP NHopGroup for Port Channel oper down #1030
Merged
sumukhatv merged 5 commits intosonic-net:masterfrom Sep 30, 2019
Merged
Update ECMP NHopGroup for Port Channel oper down #1030sumukhatv merged 5 commits intosonic-net:masterfrom
sumukhatv merged 5 commits intosonic-net:masterfrom
Conversation
added 3 commits
August 9, 2019 14:46
on detecting portchannel down
Collaborator
|
@sumukhatv , would need to add a VS test for this change |
sumukhatv
changed the title
1. Add 4 PortChannels 2. Add to nexthop group
prsunny
reviewed
Sep 18, 2019
after bringing down a portchannel
prsunny
approved these changes
Sep 30, 2019
| tbl = swsscommon.Table(self.cdb, "PORTCHANNEL") | ||
| fvs = swsscommon.FieldValuePairs([("admin_status", "up"),("mtu", "9100"),("oper_status", "up")]) | ||
|
|
||
| tbl.set("PortChannel001", fvs) |
Collaborator
There was a problem hiding this comment.
I see that there is code repetition. If you can create a list of Portchannels and call function to do set, del operation, it will simplify and reduce the code. Just a suggestion.
wendani
reviewed
Sep 26, 2020
| tbl._del("PortChannel002") | ||
| tbl._del("PortChannel003") | ||
| tbl._del("PortChannel004") | ||
| time.sleep(1) |
Contributor
There was a problem hiding this comment.
Restore eth0 up. If test_port.py follows this test, we got persistent test failure.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Remove nexthop member from nexthopgroup on detecting portchannel down * Code cleanup * Fix spacing errors * Create new Test 1. Add 4 PortChannels 2. Add to nexthop group * Check for 3 NH group members after bringing down a portchannel
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
Add new table names as per sonic-net/SONiC#2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Remove nexthop member from nexthop group immediately when port-channel oper status becomes down
Why I did it
This will reduce the response time for port-channel down event thus helping prevent packet drops
How I verified it
Details if related
Timeline of events on a DUT immediately after bringing down a portchannel:
21:20:51 Updated NextHop group to 3 members
21:20:52 First v4 route update
21:21:13 Last v4 route update
21:21:13 4 member NextHop group deleted (v4)
21:21:13 3 member NextHop group created (v6)
21:21:13 First v6 route update
21:21:16 Last v6 route update