Skip to content

Add definition for MEMORY_STATISTICS table in schema#898

Merged
qiluo-msft merged 9 commits intosonic-net:masterfrom
Arham-Nasir:feature/memory-statistics
Dec 3, 2024
Merged

Add definition for MEMORY_STATISTICS table in schema#898
qiluo-msft merged 9 commits intosonic-net:masterfrom
Arham-Nasir:feature/memory-statistics

Conversation

@Arham-Nasir
Copy link
Copy Markdown
Contributor

@Arham-Nasir Arham-Nasir commented Aug 12, 2024

define table in common/schema.h file of sonic-swss-common

@Arham-Nasir
defined memory statistics table
120a7b6
@Arham-Nasir
updated the memory statistics table defination
b183bc8 
Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>
@Arham-Nasir
Added inverted comma at the end of memory statistics table defination
8d077f3 
Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>
@Arham-Nasir Arham-Nasir changed the title Define MEMORY_STATISTICS_Table in sonic-swss-common Adding MEMORY_STATISTICS_Table Sep 20, 2024
@ridahanif96 ridahanif96 mentioned this pull request Oct 14, 2024
Merged
@FengPan-Frank
Copy link
Copy Markdown
Contributor

FengPan-Frank commented Oct 15, 2024

LGTM, pls resolve the conflicts.

@Arham-Nasir
Copy link
Copy Markdown
Contributor Author

Arham-Nasir commented Oct 16, 2024

LGTM, pls resolve the conflicts.

@FengPan-Frank , thank you for the review! I checked again. Please let me know if you need any further information.

@Arham-Nasir Arham-Nasir changed the title Adding MEMORY_STATISTICS_Table Add definition for MEMORY_STATISTICS table in schema Oct 23, 2024
@Arham-Nasir
Copy link
Copy Markdown
Contributor Author

Arham-Nasir commented Oct 23, 2024

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 23, 2024

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 23, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@ridahanif96
Copy link
Copy Markdown

ridahanif96 commented Oct 25, 2024

@xincunli-sonic @qiluo-msft @zbud-msft pls help review this PR. All swsscommon/db changes are getting failed since this PR in not Part of master

ridahanif96
ridahanif96 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown

@ridahanif96 ridahanif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me , please wait till all checks passes and merge this PR!

@ridahanif96
Copy link
Copy Markdown

ridahanif96 commented Nov 6, 2024

Hi @FengPan-Frank , can you please help merge this PR or get it merged with help of authorized person

@FengPan-Frank
Copy link
Copy Markdown
Contributor

FengPan-Frank commented Nov 6, 2024

Hi @FengPan-Frank , can you please help merge this PR or get it merged with help of authorized person

I don't have merge permission, either. pls check with qiluo-msft

@ridahanif96
Copy link
Copy Markdown

ridahanif96 commented Nov 6, 2024

@qiluo-msft can you please help review this feature and PRs.

@qiluo-msft qiluo-msft merged commit fb6ce44 into sonic-net:master Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridahanif96 ridahanif96 ridahanif96 approved these changes

@FengPan-Frank FengPan-Frank FengPan-Frank approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Arham-Nasir @FengPan-Frank @mssonicbld @ridahanif96 @qiluo-msft