Revert "Fix the issue of ignoring callback calls for removed keys. (#789)"#804
Merged
qiluo-msft merged 1 commit intomasterfrom Aug 1, 2023
Merged
Revert "Fix the issue of ignoring callback calls for removed keys. (#789)"#804qiluo-msft merged 1 commit intomasterfrom
qiluo-msft merged 1 commit intomasterfrom
Conversation
)" This reverts commit e0f394c.
liuh-80
approved these changes
Jul 24, 2023
6 tasks
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@oleksandrivantsiv , the PR #789 can't revert because vstest keeps failed, could you please check and fix to revert it? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SviatoslavBoichuk
pushed a commit
to SviatoslavBoichuk/sonic-swss-common
that referenced
this pull request
Sep 7, 2023
…onic-net#789)" (sonic-net#804) This reverts commit e0f394c. The reason is unexpected behavior change of `get_entry`. ref: sonic-net#789 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e0f394c.
The reason is unexpected behavior change of
get_entry. ref: #789 (comment)