Merged
Conversation
|
|
8 tasks
prsunny
approved these changes
Dec 6, 2022
Contributor
|
is there an HLD for this feature? |
Contributor
Author
|
Hi Sunny,
Thank you for the approval. No, we don't have an HLD for this feature. The
tc-dot1p qos map implementation is similar to other qos maps (dot1p-tc,
dscp-tc, tc-queue, etc.) already supported in Community Sonic. With
tc-dot1p and tc-dscp qos map support, we can configure remarking of dot1p
priorities and dscp fields. Will you be reviewing the PR raised for the
same feature in swss repo, as well?
Thank you
…On Tue, Dec 6, 2022 at 11:43 PM Prince Sunny ***@***.***> wrote:
is there an HLD for this feature?
—
Reply to this email directly, view it on GitHub
<#721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4J5MWU4N6WU77JYQIOL7LDWL565XANCNFSM6AAAAAASVJVURE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Regards,
-Divya
|
Contributor
Author
|
This is a gentle reminder to complete this review. Another PR (sonic-net/sonic-swss#2559) is dependent on this PR. Build will fail on PR 2559 without this committed. |
8 tasks
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2023
*This PR has been raised to enable support for tc-dot1p qos map configuration.
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
*This PR has been raised to enable support for tc-dot1p qos map configuration.
Contributor
|
Hi @dmukun , could you add yang model for this table? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to sonic-net/sonic-swss#2559
This PR has been raised to enable support for tc-dot1p qos map configuration. The above mentioned PR is dependent on this commit.
Which release branch to backport (provide reason below if selected)