[Fast/Warm restart] Implement helper class for waiting restart done#691
Merged
qiluo-msft merged 9 commits intosonic-net:masterfrom Oct 18, 2022
Merged
[Fast/Warm restart] Implement helper class for waiting restart done#691qiluo-msft merged 9 commits intosonic-net:masterfrom
qiluo-msft merged 9 commits intosonic-net:masterfrom
Conversation
Junchao-Mellanox
requested review from
arfeigin,
qiluo-msft,
stephenxs and
vaibhavhd
stephenxs
previously approved these changes
Sep 19, 2022
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
reviewed
Sep 20, 2022
Collaborator
Author
|
/azpw run Azure.sonic-swss-common |
Collaborator
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss-common |
Collaborator
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
previously approved these changes
Sep 23, 2022
Collaborator
Author
|
Hi @qiluo-msft @liuh-80, could you please review and sign-off? |
liuh-80
reviewed
Sep 23, 2022
stephenxs
reviewed
Sep 23, 2022
…ther library to use
stephenxs
previously approved these changes
Sep 26, 2022
Collaborator
Author
|
/azpw run Azure.sonic-swss-common |
Collaborator
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Oct 9, 2022
common/restart_waiter.cpp
Outdated
| return false; | ||
| } | ||
|
|
||
| selectTimeout -= delay; |
Contributor
Collaborator
Author
There was a problem hiding this comment.
Not sure I understand. Let's say maxWaitTime is 90 seconds, thus initial selectTimeout is 90000 ms. For first iteration, restart is not done, and delay is 10000 ms. To make sure maxWaitTime is 90, the selectTimeout should be adjusted (90000 - 10000) = 80000 seconds because we have already waited 10 seconds.
Collaborator
Author
|
/azpw run Azure.sonic-swss-common |
Collaborator
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss-common |
Collaborator
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
approved these changes
Oct 12, 2022
Collaborator
Author
|
Hi @vaibhavhd @liuh-80 @stephenxs @arfeigin , could you please review and sign-off? |
stephenxs
approved these changes
Oct 14, 2022
vaibhavhd
reviewed
Oct 14, 2022
vaibhavhd
approved these changes
Oct 18, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Update sonic-swss-common submodule pointer to include the following: * abda263 Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB ([sonic-net#687](sonic-net/sonic-swss-common#687)) * d0fdf62 Check whether a pointer created by dynamic_cast is null before using it. ([sonic-net#689](sonic-net/sonic-swss-common#689)) * 2cae742 [Fast/Warm restart] Implement helper class for waiting restart done ([sonic-net#691](sonic-net/sonic-swss-common#691)) Signed-off-by: dprital <[email protected]>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Why I did this?
Daemons which are not related to warm/fast restart might affect the performance of warm/fast restart. A hardcoded start up delay is the current solution to avoid this.
This PR implements a function to wait warm/fast restart done. This function provided a efficiency and graceful way for daemons to wait warm/fast restart done.
How I did it?
Implement a utility function RestartWaiter::waitRestartDone. This function waits warm restart done flag in STATE DB and return true if the flag is set by warm restart finalizer. This function is also exposed as python extension so that python daemons can utilize it.
This PR depends on new fastboot design: https://github.com/sonic-net/SONiC/blob/master/doc/fast-reboot/Fast-reboot_Flow_Improvements_HLD.md