Skip to content

Remove signal handler and improve PubSub::listem_message()#629

Closed
liuh-80 wants to merge 17 commits intosonic-net:masterfrom
liuh-80:dev/liuh/remove-signal-handler
Closed

Remove signal handler and improve PubSub::listem_message()#629
liuh-80 wants to merge 17 commits intosonic-net:masterfrom
liuh-80:dev/liuh/remove-signal-handler

Conversation

@liuh-80
Copy link
Copy Markdown
Contributor

@liuh-80 liuh-80 commented Jun 10, 2022

No description provided.

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 10, 2022

Code change in this PR will be test by sonic-net/sonic-buildimage#11100 to makesure existed code not break.

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Pull request contains merge conflicts.

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 15, 2022

Following UT failed after remove the retry inside pubsub, need investigation failed reason and fix:
2022-06-14T07:24:18.1567596Z test_sflow.py::TestSflow::test_defaultGlobal FAILED [ 78%]
2022-06-14T07:24:59.2537746Z test_sflow.py::TestSflow::test_globalAll FAILED [ 78%]
2022-06-14T07:25:40.4894964Z test_sflow.py::TestSflow::test_InterfaceSet FAILED [ 78%]
2022-06-14T07:26:21.6047747Z test_sflow.py::TestSflow::test_defaultRate FAILED [ 78%]
2022-06-14T07:27:02.6082874Z test_sflow.py::TestSflow::test_ConfigDel FAILED [ 78%]
2022-06-14T07:27:43.8002363Z test_sflow.py::TestSflow::test_SamplingRatePortCfgUpdate FAILED [ 79%]
2022-06-14T07:28:24.8800435Z test_sflow.py::TestSflow::test_SamplingRateManualUpdate FAILED [ 79%]
2022-06-14T07:29:06.0175690Z test_sflow.py::TestSflow::test_InterfaceDisableAllUpdate FAILED [ 79%]
2022-06-14T07:29:47.0739828Z test_sflow.py::TestSflow::test_InterfaceDefaultSampleRate FAILED [ 79%]
2022-06-14T07:30:28.8044684Z test_sflow.py::TestSflow::test_Teardown FAILED [ 79%]

Fixed.

@liuh-80 liuh-80 force-pushed the dev/liuh/remove-signal-handler branch from 13c19ba to 01d443c Compare June 15, 2022 07:09
@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 15, 2022

Build SAI failed because following error:

2022-06-15T09:19:32.5006579Z tests: tests.cpp:843: void test_watchdog_timer_clock_rollback(): Assertion `settimeofday(&currentTime, NULL) == 0' failed.
2022-06-15T09:19:33.0057529Z /bin/bash: line 5: 13008 Aborted (core dumped) ${dir}$tst

Seems not caused by code change, some other PR also failed with same reason:
https://dev.azure.com/mssonic/build/_build/results?buildId=110343&view=logs&j=61b7eb0d-78fa-5af5-6df0-b6f82d3891a8&t=6a34388b-e109-5be6-7b42-af0762c91bba

@liuh-80 liuh-80 marked this pull request as ready for review June 15, 2022 09:32
@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jun 16, 2022

The code chaneg in this PR seems dupe with https://github.com/Azure/sonic-swss-common/pull/624/files

So will discussion with stepanblyschak and merge code to his PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant