Skip to content

Ported Marvell armhf build on amd64 host for debian buster to use cross-comp… #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 4 commits into from
Nov 18, 2021
Merged

Ported Marvell armhf build on amd64 host for debian buster to use cross-comp… #501

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30db966
Ported Marvell armhf build on x86 for debian buster to use cross-comp…
Jun 30, 2021
95c7b57
Merge branch 'master' into master
gregshpit Sep 19, 2021
deccc8c
Update configure.ac
gregshpit Oct 7, 2021
a206e45
Update configure.ac
gregshpit Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ AC_ARG_ENABLE(python2,
esac],[python2=true])
AM_CONDITIONAL(DEBUG, test x$debug = xtrue)
AM_CONDITIONAL(PYTHON2, test x$python2 = xtrue)
AM_CONDITIONAL(ARCH64, test `getconf LONG_BIT` = "64")
if test x$CONFIGURED_ARCH = xarmhf && test x$CROSS_BUILD_ENVIRON = xy; then
Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jul 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x$CONFIGURED_ARCH

Is it possible to generalize this rule?
The two varaibles are host arch and target arch. I believe you can get word size from them. #WontFix

Copy link
Copy Markdown
Contributor Author

@gregshpit gregshpit Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x$CONFIGURED_ARCH

Is it possible to generalize this rule?
The two varaibles are host arch and target arch. I believe you can get word size from them.

Usually you use "getconf LONG_BIT" linux command in the building environment to figure out whether the target architecture is 64 bit. However when you are using cross-compilation inside native amd64 slave image running "getconf LONG_BIT" will return info about host rather than target. The only way I see is to check directly the target architecture and whether the building environment is cross-compilation. Please suggest your solution if this is not good enough.

AM_CONDITIONAL(ARCH64, false)
else
AM_CONDITIONAL(ARCH64, test `getconf LONG_BIT` = "64")
fi

AC_PATH_PROGS(SWIG, [swig4.0 swig3.0 swig])

Expand Down