Skip to content

Deprecate RedisClient and remove unused header file #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 1 commit into from
Oct 23, 2020
Merged

Deprecate RedisClient and remove unused header file #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion common/dbinterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include <stdexcept>

#include "dbconnector.h"
#include "redisclient.h"
#include "logger.h"

namespace swss
Expand Down
1 change: 0 additions & 1 deletion common/logger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "schema.h"
#include "select.h"
#include "dbconnector.h"
#include "redisclient.h"
#include "consumerstatetable.h"
#include "producerstatetable.h"

Expand Down
1 change: 0 additions & 1 deletion common/loglevel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "schema.h"
#include "logger.h"
#include "dbconnector.h"
#include "redisclient.h"
#include "producerstatetable.h"

using namespace swss;
Expand Down
6 changes: 2 additions & 4 deletions common/redisclient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,8 @@ class RedisClient

private:
swss::DBConnector *m_db;
};

// TODO: mark above class: __attribute__ ((__deprecated__));
// After remove all the caller code
} __attribute__ ((__deprecated__));
// This class is deprecated. Please use DBConnector class instead.

}

Expand Down
1 change: 0 additions & 1 deletion tests/fdb_flush.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#include "common/producertable.h"
#include "common/consumertable.h"
#include "common/redisapi.h"
#include "common/redisclient.h"

#include <inttypes.h>
#include <iostream>
Expand Down
1 change: 0 additions & 1 deletion tests/logger_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "common/dbconnector.h"
#include "common/redisclient.h"
#include "common/producerstatetable.h"
#include "common/consumerstatetable.h"
#include "common/select.h"
Expand Down
1 change: 0 additions & 1 deletion tests/redis_state_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "common/table.h"
#include "common/producerstatetable.h"
#include "common/consumerstatetable.h"
#include "common/redisclient.h"

using namespace std;
using namespace swss;
Expand Down
1 change: 0 additions & 1 deletion tests/redis_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "common/selectableevent.h"
#include "common/selectabletimer.h"
#include "common/table.h"
#include "common/redisclient.h"
#include "common/dbinterface.h"
#include "common/sonicv2connector.h"

Expand Down