Move RedisClient functions into DBConnector#382
Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom Sep 17, 2020
Merged
Conversation
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
qiluo-msft
requested review from
daall,
jleveque,
kcudnik,
lguohan,
pavel-shirshov,
prsunny,
shi-su and
yxieca
prsunny
approved these changes
Sep 17, 2020
qiluo-msft
added a commit
to qiluo-msft/sonic-swss
that referenced
this pull request
Sep 17, 2020
qiluo-msft
added a commit
to qiluo-msft/sonic-sairedis
that referenced
this pull request
Sep 17, 2020
qiluo-msft
added a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Sep 17, 2020
qiluo-msft
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Sep 18, 2020
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Dec 9, 2020
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Dec 9, 2020
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Dec 20, 2020
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Dec 20, 2020
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Dec 21, 2020
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Jan 21, 2021
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Jan 21, 2021
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
anish-n
pushed a commit
to anish-n/sonic-swss
that referenced
this pull request
Feb 25, 2021
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Feb 25, 2021
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Jul 20, 2021
kktheballer
pushed a commit
to kktheballer/sonic-swss-common
that referenced
this pull request
Jul 20, 2021
* Move RedisClient functions into DBConnector * RedisClient redirects all functions to DBConnector * Remove cpp file * Remove RedisClient * Add TODO comment
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
* Default implementation of under/over speed checks * Update comment, remove requirement for float conversion * Fan test coverage
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member functions of class RedisClient fit well in the class DBConnector, and there is not benefit of standalone RedisClient class. So we are trying to deprecated the class RedisClient.
Steps: