Merged
Conversation
)" This reverts commit 1943e2b.
abdosi
approved these changes
Aug 12, 2020
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
* Update api's rendering maxduration Update ModulePwrUp, ModulePwrDown, DataPathInit and DataPathDeInit api's to handle unsupported values * Update CMIS module timing enums with reserved values * Update the api's rendering duration values of CMIS modules * Update the api's rendering duration values of CMIS modules * Update the api's rendering duration values of CMIS modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
There are use cases of DBConnector in sonic-sairedis, sonic-swss and they use either
(1) the DBConnector defined in sonic-swss-common directly and talk to the REDIS DB
(2) the mock DBConnector defined in sonic-swss/tests/mock_tests/mock_dbconnector.cpp, which fakes the DB
There were failures seen in the sonic-swss PR build, which was in turn found to be because we are not using the latest sonic-sairedis build while doing the PR build. But on trying to get the sonic-sairedis build with this new sonic-swss-common , there are failures in Warm Restart tests.
So there is a dependent modules which needs to be verified before committing this change. Reverting this now to make the sonic-swss builds pass.